fix(cmd): Change tense for deletion of active context#1412
Merged
phm07 merged 1 commit intoMay 22, 2026
Merged
Conversation
"You are deleting" implies that I can abort the action somehow. In other user interfaces, it's common to end sentences like this with "Are you sure?". Given that the hcloud CLI doesn't do this and happily deletes the context, I changed the wording to indicate that the action was executed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 72.80% 67.74% -5.07%
==========================================
Files 300 300
Lines 11104 11104
==========================================
- Hits 8084 7522 -562
- Misses 2120 2634 +514
- Partials 900 948 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phm07
approved these changes
May 22, 2026
Contributor
|
Thanks for the contribution 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"You are deleting" implies that I can abort the action somehow. In other user interfaces, it's common to end sentences like this with "Are you sure?". Given that the hcloud CLI doesn't do this and happily deletes the context, I changed the wording to indicate that the action was executed.