ci: only publish helm-chart once (#1045)

Each file found with "release.extra_files" will become an artifact.
Those artifacts cannot be filtered by "publishers[].ids". If the
"release" step does not run (e.g. snapshot), the publishers will not
have any artifacts to publish.

This make the "release.extra_files" glob pattern more strict, and ensure
that the helm chart publisher only runs once, for the helm chart
package.

Author: jooola

.goreleaser.yml

@@ -71,15 +71,18 @@ release:
     - archive
   extra_files:
     - glob: ./deploy/ccm*.yaml
-    - glob: ./hcloud-cloud-controller-manager-*.tgz
+    - glob: ./hcloud-cloud-controller-manager-{{ .Version }}.tgz
 
 publishers:
   - name: publish-helm-chart
 
-    # Only execute once by filtering all ids, and only running for the checksum.
+    # Filter all artifacts, except the one generated by "release.extra_files" that
+    # cannot be filtered. If the "release" step does not run, the publisher will have
+    # not artifacts to publish.
     ids: ["none"]
-    checksum: true
 
     cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ .Version }}.tgz
     env:
       - CHART_REPO_REMOTE={{ .Env.CHART_REPO_REMOTE }}
+      # Ensures we only publish once, when $1 == $GORELEASER_ARTIFACT_FILE
+      - GORELEASER_ARTIFACT_FILE={{ .ArtifactPath }}

scripts/publish-helm-chart.sh

@@ -13,6 +13,12 @@ if [[ -z "$CHART_FILE" ]]; then
   exit 1
 fi
 
+# Ensures we only publish once, when $1 == $GORELEASER_ARTIFACT_FILE
+if [[ -n "${GORELEASER_ARTIFACT_FILE}" && "${GORELEASER_ARTIFACT_FILE}" != "${CHART_FILE}" ]]; then
+  echo "skipping artifact: ${GORELEASER_ARTIFACT_FILE}" >&2
+  exit 0
+fi
+
 TMP_DIR=$(mktemp --directory chart-repo.XXXXX)
 # shellcheck disable=SC2064
 trap "rm -Rf '$(realpath "$TMP_DIR")'" EXIT