refactor: error message spelling

Author: lukasmetzner

hcloud/routes.go

@@ -152,26 +152,26 @@ func (r *routes) resolveRouteTarget(ctx context.Context, nodeName string) (*core
 
 	id, isCloudServer, err := providerid.ToServerID(node.Spec.ProviderID)
 	if err != nil {
-		return nil, nil, fmt.Errorf("error parsing providerID %q for node %s: %w", node.Spec.ProviderID, nodeName, err)
+		return nil, nil, fmt.Errorf("error parsing provider id %q for node %s: %w", node.Spec.ProviderID, nodeName, err)
 	}
 	if !isCloudServer {
-		return nil, nil, fmt.Errorf("node %s is not a Cloud server, routes are only supported for Cloud servers", node.Name)
+		return nil, nil, fmt.Errorf("node %s is not a cloud server, routes are only supported for cloud servers", node.Name)
 	}
 
 	server, err := r.serverCache.ByID(ctx, id)
 	if errors.Is(err, hcops.ErrNotFound) {
 		server, err = r.serverCache.ByName(ctx, node.Name)
 	}
 	if err != nil {
-		return nil, nil, fmt.Errorf("error fetching node %s by ID: %w", nodeName, err)
+		return nil, nil, fmt.Errorf("error fetching node %s by id: %w", nodeName, err)
 	}
 
 	privNet, ok := findServerPrivateNetByID(server, r.network.ID)
 	if !ok {
 		r.serverCache.InvalidateCache()
 		server, err = r.serverCache.ByID(ctx, server.ID)
 		if err != nil {
-			return nil, nil, fmt.Errorf("error fetching node %s by ID: %w", nodeName, err)
+			return nil, nil, fmt.Errorf("error fetching node %s by id: %w", nodeName, err)
 		}
 		privNet, ok = findServerPrivateNetByID(server, r.network.ID)
 		if !ok {

hcloud/routes_test.go

@@ -250,7 +250,7 @@ func TestRoutes_CreateRoute_RobotProviderID(t *testing.T) {
 		DestinationCIDR: "10.5.0.0/24",
 	})
 	require.Error(t, err)
-	assert.ErrorContains(t, err, "not a Cloud server")
+	assert.ErrorContains(t, err, "not a cloud server")
 }
 
 // TestRoutes_CreateRoute_NodeNameDrift proves the routes controller still works when the