fix: tcp service created for service with unsupported load balancer protocol (#1129)

Fixes:
#1128

---------

Co-authored-by: Lukas Metzner <lukas.metzner@hetzner-cloud.de>

Author: xoxys

internal/hcops/load_balancer.go

@@ -933,10 +933,6 @@ func (l *LoadBalancerOps) ReconcileHCLBServices(
 			err error
 		)
 
-		portNo := int(port.Port)
-		portExists := hclbListenPorts[portNo]
-		delete(hclbListenPorts, portNo)
-
 		if port.Protocol != "" && port.Protocol != corev1.ProtocolTCP {
 			warnMsg := fmt.Sprintf(
 				"configured unsupported Hetzner Cloud load balancer protocol %s for service with name %s",
@@ -950,8 +946,13 @@ func (l *LoadBalancerOps) ReconcileHCLBServices(
 				warnMsg,
 			)
 			klog.Warning(warnMsg)
+			continue
 		}
 
+		portNo := int(port.Port)
+		portExists := hclbListenPorts[portNo]
+		delete(hclbListenPorts, portNo)
+
 		b := &hclbServiceOptsBuilder{
 			Port:    port,
 			Service: svc,

internal/hcops/load_balancer_test.go

@@ -1609,31 +1609,6 @@ func TestLoadBalancerOps_ReconcileHCLBServices(t *testing.T) {
 					MaxTargets: 25,
 				},
 			},
-			mock: func(_ *testing.T, tt *LBReconcilementTestCase) {
-				opts := hcloud.LoadBalancerAddServiceOpts{
-					Protocol:        hcloud.LoadBalancerServiceProtocolTCP,
-					ListenPort:      hcloud.Ptr(80),
-					DestinationPort: hcloud.Ptr(8080),
-					HealthCheck: &hcloud.LoadBalancerAddServiceOptsHealthCheck{
-						Protocol: hcloud.LoadBalancerServiceProtocolTCP,
-						Port:     hcloud.Ptr(8080),
-					},
-				}
-				action := tt.fx.MockAddService(opts, tt.initialLB, nil)
-				tt.fx.ActionClient.On("WaitFor", tt.fx.Ctx, action).Return(nil)
-
-				opts = hcloud.LoadBalancerAddServiceOpts{
-					Protocol:        hcloud.LoadBalancerServiceProtocolTCP,
-					ListenPort:      hcloud.Ptr(443),
-					DestinationPort: hcloud.Ptr(8443),
-					HealthCheck: &hcloud.LoadBalancerAddServiceOptsHealthCheck{
-						Protocol: hcloud.LoadBalancerServiceProtocolTCP,
-						Port:     hcloud.Ptr(8443),
-					},
-				}
-				action = tt.fx.MockAddService(opts, tt.initialLB, nil)
-				tt.fx.ActionClient.On("WaitFor", tt.fx.Ctx, action).Return(nil)
-			},
 			perform: func(t *testing.T, tt *LBReconcilementTestCase) {
 				_, err := tt.fx.LBOps.ReconcileHCLBServices(tt.fx.Ctx, tt.initialLB, tt.service)
 				assert.NoError(t, err)