Remove "proxyProtocolEnabledDefault" because it was always false.#1123
Closed
guettli wants to merge 1 commit intohetznercloud:mainfrom
Closed
Remove "proxyProtocolEnabledDefault" because it was always false.#1123guettli wants to merge 1 commit intohetznercloud:mainfrom
guettli wants to merge 1 commit intohetznercloud:mainfrom
Conversation
This variable was always false.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
- Coverage 67.08% 64.75% -2.33%
==========================================
Files 23 23
Lines 2619 2619
==========================================
- Hits 1757 1696 -61
- Misses 688 755 +67
+ Partials 174 168 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Actually, we have introduced a configurable global default of the proxy protocol setting in #1052. I think it not being used here is a bug in the current code. I will fix that. |
Contributor
|
Implemented in #1131 and released in v1.29.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable was always false. It is an unexported variable that was only read but never written. It can be removed.