docs: fix certificate name plural#988
Merged
Merged
Conversation
All domains specified via the annotation `load-balancer.hetzner.cloud/http-managed-certificate-domains`, are used to create a single managed certificate. Therefore, we only the annotation `load-balancer.hetzner.cloud/http-managed-certificate-name` only accepts one name. Additionally, fixed a small typo.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
==========================================
+ Coverage 70.05% 71.27% +1.21%
==========================================
Files 22 22
Lines 3046 3046
==========================================
+ Hits 2134 2171 +37
+ Misses 743 706 -37
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apricote
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All domains specified via the annotation
load-balancer.hetzner.cloud/http-managed-certificate-domains, are used to create a single managed certificate. Therefore, the annotationload-balancer.hetzner.cloud/http-managed-certificate-nameonly accepts one name.Additionally, fixed a small typo.