refactor: inverse developer facing negations#989
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #989 +/- ##
==========================================
+ Coverage 71.27% 71.40% +0.13%
==========================================
Files 22 22
Lines 3046 3060 +14
==========================================
+ Hits 2171 2185 +14
Misses 706 706
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
reviewed
Jul 31, 2025
Features like `load-balancer.hetzner.cloud/disable-private-ingress` have a user facing negation. Up until now, these features where also negated in the codebase and inverted in conditional checks (e.g., `!disablePrivateIngress`). This PR inverses this behaviour in the codebase.
3a34845 to
ac0affe
Compare
apricote
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features like
load-balancer.hetzner.cloud/disable-private-ingresshave a user facing negation. Up until now, these features were also negated in the codebase and inverted in conditional checks (e.g.,!disablePrivateIngress). This makes the code harder to understand. This PR inverses this behavior in the codebase.