Skip to content

refactor: inverse developer facing negations#989

Merged
lukasmetzner merged 2 commits into
mainfrom
refactor-inverse-bools
Aug 1, 2025
Merged

refactor: inverse developer facing negations#989
lukasmetzner merged 2 commits into
mainfrom
refactor-inverse-bools

Conversation

@lukasmetzner

Copy link
Copy Markdown
Contributor

Features like load-balancer.hetzner.cloud/disable-private-ingress have a user facing negation. Up until now, these features were also negated in the codebase and inverted in conditional checks (e.g., !disablePrivateIngress). This makes the code harder to understand. This PR inverses this behavior in the codebase.

@lukasmetzner lukasmetzner requested a review from a team as a code owner July 28, 2025 10:31
@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.40%. Comparing base (25021a2) to head (ac0affe).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/load_balancers.go 90.47% 2 Missing ⚠️
internal/hcops/load_balancer.go 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   71.27%   71.40%   +0.13%     
==========================================
  Files          22       22              
  Lines        3046     3060      +14     
==========================================
+ Hits         2171     2185      +14     
  Misses        706      706              
  Partials      169      169              
Flag Coverage Δ
e2e 45.28% <65.21%> (+0.05%) ⬆️
unit 67.61% <89.13%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/config/config.go Outdated
Features like `load-balancer.hetzner.cloud/disable-private-ingress` have a user facing negation. Up until now, these features where also negated in the codebase and inverted in conditional checks (e.g., `!disablePrivateIngress`). This PR inverses this behaviour in the codebase.
@lukasmetzner lukasmetzner merged commit 1db79b4 into main Aug 1, 2025
9 checks passed
@lukasmetzner lukasmetzner deleted the refactor-inverse-bools branch August 1, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants