Skip to content

test: use request_mock for all clients tests #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jooola merged 4 commits into from
Aug 14, 2025
Merged

test: use request_mock for all clients tests #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e640c56
test: use request_mock for all clients tests
jooola Aug 14, 2025
c8d9d4a
test: some manual fixes
jooola Aug 14, 2025
f8b7ec8
test: remove hetzner_client fixture
jooola Aug 14, 2025
72fa01a
style: break long argument list on multiple lines
jooola Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 56 additions & 30 deletions tests/unit/actions/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,18 @@ def test_wait_until_finished_max_retries(

class TestResourceActionsClient:
@pytest.fixture()
def actions_client(self):
return ResourceActionsClient(client=mock.MagicMock(), resource="/resource")
def actions_client(self, client: Client):
return ResourceActionsClient(client, resource="/resource")

def test_get_by_id(self, actions_client, generic_action):
actions_client._client.request.return_value = generic_action
def test_get_by_id(
self,
request_mock: mock.MagicMock,
actions_client: ActionsClient,
generic_action,
):
request_mock.return_value = generic_action
action = actions_client.get_by_id(1)
actions_client._client.request.assert_called_with(
url="/resource/actions/1", method="GET"
)
request_mock.assert_called_with(url="/resource/actions/1", method="GET")
assert action._client == actions_client._client.actions
assert action.id == 1
assert action.command == "stop_server"
Expand All @@ -94,10 +97,16 @@ def test_get_by_id(self, actions_client, generic_action):
"params",
[{}, {"status": ["active"], "sort": ["status"], "page": 2, "per_page": 10}],
)
def test_get_list(self, actions_client, generic_action_list, params):
actions_client._client.request.return_value = generic_action_list
def test_get_list(
self,
request_mock: mock.MagicMock,
actions_client: ActionsClient,
generic_action_list,
params,
):
request_mock.return_value = generic_action_list
result = actions_client.get_list(**params)
actions_client._client.request.assert_called_with(
request_mock.assert_called_with(
url="/resource/actions", method="GET", params=params
)

Expand All @@ -118,13 +127,19 @@ def test_get_list(self, actions_client, generic_action_list, params):
assert action2.command == "stop_server"

@pytest.mark.parametrize("params", [{}, {"status": ["active"], "sort": ["status"]}])
def test_get_all(self, actions_client, generic_action_list, params):
actions_client._client.request.return_value = generic_action_list
def test_get_all(
self,
request_mock: mock.MagicMock,
actions_client: ActionsClient,
generic_action_list,
params,
):
request_mock.return_value = generic_action_list
actions = actions_client.get_all(**params)

params.update({"page": 1, "per_page": 50})

actions_client._client.request.assert_called_with(
request_mock.assert_called_with(
url="/resource/actions", method="GET", params=params
)

Expand All @@ -144,15 +159,18 @@ def test_get_all(self, actions_client, generic_action_list, params):

class TestActionsClient:
@pytest.fixture()
def actions_client(self):
return ActionsClient(client=mock.MagicMock())
def actions_client(self, client: Client):
return ActionsClient(client)

def test_get_by_id(self, actions_client, generic_action):
actions_client._client.request.return_value = generic_action
def test_get_by_id(
self,
request_mock: mock.MagicMock,
actions_client: ActionsClient,
generic_action,
):
request_mock.return_value = generic_action
action = actions_client.get_by_id(1)
actions_client._client.request.assert_called_with(
url="/actions/1", method="GET"
)
request_mock.assert_called_with(url="/actions/1", method="GET")
assert action._client == actions_client._client.actions
assert action.id == 1
assert action.command == "stop_server"
Expand All @@ -161,13 +179,17 @@ def test_get_by_id(self, actions_client, generic_action):
"params",
[{}, {"status": ["active"], "sort": ["status"], "page": 2, "per_page": 10}],
)
def test_get_list(self, actions_client, generic_action_list, params):
actions_client._client.request.return_value = generic_action_list
def test_get_list(
self,
request_mock: mock.MagicMock,
actions_client: ActionsClient,
generic_action_list,
params,
):
request_mock.return_value = generic_action_list
with pytest.deprecated_call():
result = actions_client.get_list(**params)
actions_client._client.request.assert_called_with(
url="/actions", method="GET", params=params
)
request_mock.assert_called_with(url="/actions", method="GET", params=params)

assert result.meta is not None

Expand All @@ -186,16 +208,20 @@ def test_get_list(self, actions_client, generic_action_list, params):
assert action2.command == "stop_server"

@pytest.mark.parametrize("params", [{}, {"status": ["active"], "sort": ["status"]}])
def test_get_all(self, actions_client, generic_action_list, params):
actions_client._client.request.return_value = generic_action_list
def test_get_all(
self,
request_mock: mock.MagicMock,
actions_client: ActionsClient,
generic_action_list,
params,
):
request_mock.return_value = generic_action_list
with pytest.deprecated_call():
actions = actions_client.get_all(**params)

params.update({"page": 1, "per_page": 50})

actions_client._client.request.assert_called_with(
url="/actions", method="GET", params=params
)
request_mock.assert_called_with(url="/actions", method="GET", params=params)

assert len(actions) == 2

Expand Down
Loading