feat(primary-ip): make auto_delete attribute optional#1429
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1429 +/- ##
===========================================
- Coverage 72.98% 37.78% -35.20%
===========================================
Files 112 112
Lines 12533 12536 +3
===========================================
- Hits 9147 4737 -4410
- Misses 2320 7740 +5420
+ Partials 1066 59 -1007
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auto_delete attribute is now optionalauto_delete attribute optional
The auto_delete attribute is currently required, but we recommend always setting its value to false:
Setting `auto_delete` to `false` is recommended, because if a server assigned to the managed ip
is getting deleted, it will also delete the primary IP which will break the terraform state.
This change makes the `auto_delete` attribute optional, and leverage the API default value (false). Simplifying users configuration and use a sane API default.
https://docs.hetzner.cloud/reference/cloud#tag/primary-ips/create_primary_ip
25047e2 to
482629d
Compare
lukasmetzner
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
auto_deleteattribute is currently required, but we recommend always setting its value tofalse:This change makes the
auto_deleteattribute optional, and defaults to false. Simplifying user's configurations and using a recommended default.https://docs.hetzner.cloud/reference/cloud#tag/primary-ips/create_primary_ip