Fix crash in ExtractTeraTypeFromEmbed from unvalidated Split

hexbyt3 · hexbyt3 · commit cffe91e576fc · 2025-10-14T20:20:51.000-05:00
Add bounds check before accessing Split result to prevent IndexOutOfRangeException if embed format is malformed or missing colon separator.
diff --git a/SysBot.Pokemon/SV/BotRaid/RotatingRaidBotSV.cs b/SysBot.Pokemon/SV/BotRaid/RotatingRaidBotSV.cs
@@ -1763,9 +1763,13 @@ private static string ExtractTeraTypeFromEmbed(Embed embed)
                 var teraTypeLine = lines.FirstOrDefault(l => l.StartsWith("**TeraType:**"));
                 if (teraTypeLine != null)
                 {
-                    var teraType = teraTypeLine.Split(':')[1].Trim();
-                    teraType = teraType.Replace("*", "").Trim();
-                    return teraType;
+                    var parts = teraTypeLine.Split(':');
+                    if (parts.Length >= 2)
+                    {
+                        var teraType = parts[1].Trim();
+                        teraType = teraType.Replace("*", "").Trim();
+                        return teraType;
+                    }
                 }
             }
             return "Fairy"; // Default value if something goes wrong

Original file line number	Diff line number	Diff line change
`@@ -1763,9 +1763,13 @@ private static string ExtractTeraTypeFromEmbed(Embed embed)`
`1763`	`1763`	`var teraTypeLine = lines.FirstOrDefault(l => l.StartsWith("TeraType:"));`
`1764`	`1764`	`if (teraTypeLine != null)`
`1765`	`1765`	`{`
`1766`		`- var teraType = teraTypeLine.Split(':')[1].Trim();`
`1767`		`- teraType = teraType.Replace("*", "").Trim();`
`1768`		`- return teraType;`
	`1766`	`+ var parts = teraTypeLine.Split(':');`
	`1767`	`+ if (parts.Length >= 2)`
	`1768`	`+ {`
	`1769`	`+ var teraType = parts[1].Trim();`
	`1770`	`+ teraType = teraType.Replace("*", "").Trim();`
	`1771`	`+ return teraType;`
	`1772`	`+ }`
`1769`	`1773`	`}`
`1770`	`1774`	`}`
`1771`	`1775`	`return "Fairy"; // Default value if something goes wrong`