fix: skip env config write on metadata-only project updates

- updateProject: don't call overrideEnvironmentConfigOverride when there
  are no env-config keys to set, so metadata-only PATCHes (e.g.
  onboarding_state) on local-emulator projects no longer trip the
  LOCAL_EMULATOR_ENV_CONFIG_BLOCKED guard.
- Drop the "rejects non-existent config files" test: the local-emulator
  POST endpoint now auto-creates the file (#1413), and that path is
  already covered by "writes default config for empty files".
- failed-emails-digest test: poll until both the verify-email and
  test-email failures have been recorded instead of relying on a fixed
  10s wait, and restore the original snapshot.

Author: mantrakp04

apps/backend/src/lib/projects.tsx

@@ -314,11 +314,13 @@ export async function createOrUpdateProjectWithLegacyConfig(
     configOverrideOverride['apps.installed.authentication.enabled'] ??= true;
     configOverrideOverride['apps.installed.emails.enabled'] ??= true;
   }
-  await overrideEnvironmentConfigOverride({
-    projectId: projectId,
-    branchId: branchId,
-    environmentConfigOverrideOverride: configOverrideOverride,
-  });
+  if (Object.keys(configOverrideOverride).length > 0) {
+    await overrideEnvironmentConfigOverride({
+      projectId: projectId,
+      branchId: branchId,
+      environmentConfigOverrideOverride: configOverrideOverride,
+    });
+  }
   const result = await getProject(projectId);
   if (!result) {
     throw new StackAssertionError("Project not found after creation/update", { projectId });

apps/e2e/tests/backend/endpoints/api/v1/internal/failed-emails-digest.test.ts

@@ -102,24 +102,31 @@ describe("with valid credentials", () => {
       }
     `);
 
-    await wait(10_000);
-
-    const response = await niceBackendFetch("/api/v1/internal/failed-emails-digest", {
-      method: "POST",
-      headers: { "Authorization": "Bearer mock_cron_secret" },
-      query: {
-        dry_run: `${isDryRun}`,
-      },
-    });
-    expect(response.status).toBe(200);
-
-    const failedEmailsByTenancy = response.body.failed_emails_by_tenancy;
-    const mockProjectFailedEmails = failedEmailsByTenancy.filter(
-      (batch: any) => batch.tenant_owner_emails.includes(backendContext.value.mailbox.emailAddress)
-    ).map((batch: any) => ({
-      ...batch,
-      emails: [...batch.emails].sort((a, b) => stringCompare(a.subject, b.subject)),
-    }));
+    // Failed emails are written asynchronously; poll until both the test
+    // email and the verification email have been recorded for our tenancy.
+    let mockProjectFailedEmails: any[] = [];
+    for (let i = 0; i < 30; i++) {
+      const response = await niceBackendFetch("/api/v1/internal/failed-emails-digest", {
+        method: "POST",
+        headers: { "Authorization": "Bearer mock_cron_secret" },
+        query: {
+          dry_run: `${isDryRun}`,
+        },
+      });
+      expect(response.status).toBe(200);
+      const failedEmailsByTenancy = response.body.failed_emails_by_tenancy;
+      mockProjectFailedEmails = failedEmailsByTenancy.filter(
+        (batch: any) => batch.tenant_owner_emails.includes(backendContext.value.mailbox.emailAddress)
+      ).map((batch: any) => ({
+        ...batch,
+        emails: [...batch.emails].sort((a, b) => stringCompare(a.subject, b.subject)),
+        tenant_owner_emails: [...batch.tenant_owner_emails].sort(),
+      }));
+      if (mockProjectFailedEmails[0]?.emails?.length >= 2) {
+        break;
+      }
+      await wait(1_000);
+    }
 
     if (process.env.STACK_TEST_SOURCE_OF_TRUTH === "true") {
       expect(mockProjectFailedEmails).toMatchInlineSnapshot(`[]`);
@@ -128,14 +135,21 @@ describe("with valid credentials", () => {
         [
           {
             "emails": [
+              {
+                "subject": "",
+                "to": ["User ID: <stripped UUID>"],
+              },
               {
                 "subject": "Verify your email at Test Failed Emails Project",
                 "to": ["default-mailbox--<stripped UUID>@stack-generated.example.com"],
               },
             ],
             "project_id": "<stripped UUID>",
             "tenancy_id": "<stripped UUID>",
-            "tenant_owner_emails": ["default-mailbox--<stripped UUID>@stack-generated.example.com"],
+            "tenant_owner_emails": [
+              "default-mailbox--<stripped UUID>@stack-generated.example.com",
+              "default-mailbox--<stripped UUID>@stack-generated.example.com",
+            ],
           },
         ]
       `);

apps/e2e/tests/backend/endpoints/api/v1/internal/local-emulator-project.test.ts

@@ -53,21 +53,6 @@ describe("local emulator project endpoint", () => {
     }
   });
 
-  it.runIf(isLocalEmulator)("rejects non-existent config files", async ({ expect }) => {
-    const nonExistentPath = `/tmp/${randomUUID()}/stack.config.ts`;
-
-    const response = await niceBackendFetch(LOCAL_EMULATOR_PROJECT_ENDPOINT, {
-      accessType: "admin",
-      method: "POST",
-      body: {
-        absolute_file_path: nonExistentPath,
-      },
-    });
-
-    expect(response.status).toBe(400);
-    expect(response.body).toContain("Config file not found");
-  });
-
   it.runIf(isLocalEmulator)("writes default config for empty files", async ({ expect }) => {
     const filePath = `/tmp/${randomUUID()}/stack.config.ts`;
     await fs.mkdir(path.dirname(filePath), { recursive: true });