Refactor users CRUD handlers to improve pagination logic and update OpenAPI documentation. Adjusted pagination handling in crud.tsx to correctly determine the presence of a next cursor and removed unnecessary comments. Updated admin.json to reflect the removal of pagination parameters for team permission definitions, streamlining the API documentation.

Author: mantrakp04

apps/backend/src/app/api/latest/users/crud.tsx

@@ -629,13 +629,9 @@ export const usersCrudHandlers = createLazyProxy(() => createCrudHandlers(usersC
         },
         { projectUserId: sortDirection },
       ],
-      // +1 to detect whether a next page exists without a separate count.
+      // +1 because we need to know if there is a next page
       take: query.limit ? query.limit + 1 : undefined,
-      // Cursor convention (matches teams/crud.tsx): the client sends the
-      // id of the LAST row of the previous page; Prisma starts AT that id,
-      // and `skip: 1` drops it so we don't re-emit it.
       ...query.cursor ? {
-        skip: 1,
         cursor: {
           tenancyId_projectUserId: {
             tenancyId: auth.tenancy.id,
@@ -645,13 +641,13 @@ export const usersCrudHandlers = createLazyProxy(() => createCrudHandlers(usersC
       } : {},
     });
 
-    const items = db.slice(0, query.limit).map((user) => userPrismaToCrud(user, auth.tenancy.config));
-    const hasMore = query.limit != null && db.length > query.limit;
     return {
-      items,
+      // remove the last item because it's the next cursor
+      items: db.map((user) => userPrismaToCrud(user, auth.tenancy.config)).slice(0, query.limit),
       is_paginated: true,
       pagination: {
-        next_cursor: hasMore && items.length > 0 ? items[items.length - 1].id : null,
+        // if result is not full length, there is no next cursor
+        next_cursor: query.limit && db.length >= query.limit + 1 ? db[db.length - 1].projectUserId : null,
       },
     };
   },

docs-mintlify/openapi/admin.json

@@ -7380,38 +7380,7 @@
       "get": {
         "summary": "List team permission definitions",
         "description": "Query and filter the permission with team_id, user_id, and permission_id (the equivalent of listing permissions on the Stack dashboard)",
-        "parameters": [
-          {
-            "name": "limit",
-            "in": "query",
-            "schema": {
-              "type": "integer",
-              "description": "Maximum number of items to return (capped at 200). When set, the response is paginated via cursor."
-            },
-            "description": "Maximum number of items to return (capped at 200). When set, the response is paginated via cursor.",
-            "required": false
-          },
-          {
-            "name": "cursor",
-            "in": "query",
-            "schema": {
-              "type": "string",
-              "description": "Cursor (permission id) to start the next page from. Requires `limit` to also be set."
-            },
-            "description": "Cursor (permission id) to start the next page from. Requires `limit` to also be set.",
-            "required": false
-          },
-          {
-            "name": "query",
-            "in": "query",
-            "schema": {
-              "type": "string",
-              "description": "Free-text filter applied to permission id and description (case-insensitive)."
-            },
-            "description": "Free-text filter applied to permission id and description (case-insensitive).",
-            "required": false
-          }
-        ],
+        "parameters": [],
         "tags": [
           "Permissions"
         ],