Skip to content

Commit 2f62bcf

Browse files
Developing-GamerDeveloping-Gamer
committed
Fixed Tests
1 parent ab53a32 commit 2f62bcf

8 files changed

Lines changed: 27 additions & 0 deletions

File tree

‎apps/e2e/tests/backend/endpoints/api/v1/integrations/custom/projects/provision.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ it("should be able to provision a new project if client details are correct", as
7575
"logo_full_dark_mode_url": null,
7676
"logo_full_url": null,
7777
"logo_url": null,
78+
"onboarding_status": "completed",
7879
"owner_team_id": null,
7980
},
8081
"headers": Headers { <some fields may have been hidden> },

‎apps/e2e/tests/backend/endpoints/api/v1/integrations/neon/oauth-providers.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ it("lists oauth providers", async ({ expect }) => {
132132
"logo_full_dark_mode_url": null,
133133
"logo_full_url": null,
134134
"logo_url": null,
135+
"onboarding_status": "completed",
135136
"owner_team_id": "<stripped UUID>",
136137
},
137138
"headers": Headers { <some fields may have been hidden> },

‎apps/e2e/tests/backend/endpoints/api/v1/integrations/neon/projects/current.test.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ it("get project details", async ({ expect }) => {
4545
"logo_full_dark_mode_url": null,
4646
"logo_full_url": null,
4747
"logo_url": null,
48+
"onboarding_status": "completed",
4849
"owner_team_id": "<stripped UUID>",
4950
},
5051
"headers": Headers { <some fields may have been hidden> },
@@ -102,6 +103,7 @@ it("creates and updates the basic project information of a project", async ({ ex
102103
"logo_full_dark_mode_url": null,
103104
"logo_full_url": null,
104105
"logo_url": null,
106+
"onboarding_status": "completed",
105107
"owner_team_id": "<stripped UUID>",
106108
},
107109
"headers": Headers { <some fields may have been hidden> },
@@ -175,6 +177,7 @@ it("creates and updates the email config of a project", async ({ expect }) => {
175177
"logo_full_dark_mode_url": null,
176178
"logo_full_url": null,
177179
"logo_url": null,
180+
"onboarding_status": "completed",
178181
"owner_team_id": "<stripped UUID>",
179182
},
180183
"headers": Headers { <some fields may have been hidden> },

‎apps/e2e/tests/backend/endpoints/api/v1/integrations/neon/projects/provision.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ it("should be able to provision a new project if neon client details are correct
7676
"logo_full_dark_mode_url": null,
7777
"logo_full_url": null,
7878
"logo_url": null,
79+
"onboarding_status": "completed",
7980
"owner_team_id": null,
8081
},
8182
"headers": Headers { <some fields may have been hidden> },

‎apps/e2e/tests/backend/endpoints/api/v1/project-permissions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ it("can customize default user permissions", async ({ expect }) => {
243243
"logo_full_dark_mode_url": null,
244244
"logo_full_url": null,
245245
"logo_url": null,
246+
"onboarding_status": "completed",
246247
"owner_team_id": "<stripped UUID>",
247248
},
248249
"headers": Headers { <some fields may have been hidden> },

‎apps/e2e/tests/backend/endpoints/api/v1/projects.test.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ it("creates and updates the basic project information of a project", async ({ ex
104104
"logo_full_dark_mode_url": null,
105105
"logo_full_url": null,
106106
"logo_url": null,
107+
"onboarding_status": "completed",
107108
"owner_team_id": "<stripped UUID>",
108109
},
109110
"headers": Headers { <some fields may have been hidden> },
@@ -156,6 +157,7 @@ it("updates the basic project configuration", async ({ expect }) => {
156157
"logo_full_dark_mode_url": null,
157158
"logo_full_url": null,
158159
"logo_url": null,
160+
"onboarding_status": "completed",
159161
"owner_team_id": "<stripped UUID>",
160162
},
161163
"headers": Headers { <some fields may have been hidden> },
@@ -213,6 +215,7 @@ it("updates the project domains configuration", async ({ expect }) => {
213215
"logo_full_dark_mode_url": null,
214216
"logo_full_url": null,
215217
"logo_url": null,
218+
"onboarding_status": "completed",
216219
"owner_team_id": "<stripped UUID>",
217220
},
218221
"headers": Headers { <some fields may have been hidden> },
@@ -276,6 +279,7 @@ it("updates the project domains configuration", async ({ expect }) => {
276279
"logo_full_dark_mode_url": null,
277280
"logo_full_url": null,
278281
"logo_url": null,
282+
"onboarding_status": "completed",
279283
"owner_team_id": "<stripped UUID>",
280284
},
281285
"headers": Headers { <some fields may have been hidden> },
@@ -333,6 +337,7 @@ it("should allow insecure HTTP connections if insecureHttp is true", async ({ ex
333337
"logo_full_dark_mode_url": null,
334338
"logo_full_url": null,
335339
"logo_url": null,
340+
"onboarding_status": "completed",
336341
"owner_team_id": "<stripped UUID>",
337342
},
338343
"headers": Headers { <some fields may have been hidden> },
@@ -433,6 +438,7 @@ it("updates the project email configuration", async ({ expect }) => {
433438
"logo_full_dark_mode_url": null,
434439
"logo_full_url": null,
435440
"logo_url": null,
441+
"onboarding_status": "completed",
436442
"owner_team_id": "<stripped UUID>",
437443
},
438444
"headers": Headers { <some fields may have been hidden> },
@@ -495,6 +501,7 @@ it("updates the project email configuration", async ({ expect }) => {
495501
"logo_full_dark_mode_url": null,
496502
"logo_full_url": null,
497503
"logo_url": null,
504+
"onboarding_status": "completed",
498505
"owner_team_id": "<stripped UUID>",
499506
},
500507
"headers": Headers { <some fields may have been hidden> },
@@ -543,6 +550,7 @@ it("updates the project email configuration", async ({ expect }) => {
543550
"logo_full_dark_mode_url": null,
544551
"logo_full_url": null,
545552
"logo_url": null,
553+
"onboarding_status": "completed",
546554
"owner_team_id": "<stripped UUID>",
547555
},
548556
"headers": Headers { <some fields may have been hidden> },
@@ -591,6 +599,7 @@ it("updates the project email configuration", async ({ expect }) => {
591599
"logo_full_dark_mode_url": null,
592600
"logo_full_url": null,
593601
"logo_url": null,
602+
"onboarding_status": "completed",
594603
"owner_team_id": "<stripped UUID>",
595604
},
596605
"headers": Headers { <some fields may have been hidden> },
@@ -653,6 +662,7 @@ it("updates the project email configuration", async ({ expect }) => {
653662
"logo_full_dark_mode_url": null,
654663
"logo_full_url": null,
655664
"logo_url": null,
665+
"onboarding_status": "completed",
656666
"owner_team_id": "<stripped UUID>",
657667
},
658668
"headers": Headers { <some fields may have been hidden> },
@@ -828,6 +838,7 @@ it("updates the project oauth configuration", async ({ expect }) => {
828838
"logo_full_dark_mode_url": null,
829839
"logo_full_url": null,
830840
"logo_url": null,
841+
"onboarding_status": "completed",
831842
"owner_team_id": "<stripped UUID>",
832843
},
833844
"headers": Headers { <some fields may have been hidden> },
@@ -883,6 +894,7 @@ it("updates the project oauth configuration", async ({ expect }) => {
883894
"logo_full_dark_mode_url": null,
884895
"logo_full_url": null,
885896
"logo_url": null,
897+
"onboarding_status": "completed",
886898
"owner_team_id": "<stripped UUID>",
887899
},
888900
"headers": Headers { <some fields may have been hidden> },
@@ -942,6 +954,7 @@ it("updates the project oauth configuration", async ({ expect }) => {
942954
"logo_full_dark_mode_url": null,
943955
"logo_full_url": null,
944956
"logo_url": null,
957+
"onboarding_status": "completed",
945958
"owner_team_id": "<stripped UUID>",
946959
},
947960
"headers": Headers { <some fields may have been hidden> },
@@ -996,6 +1009,7 @@ it("updates the project oauth configuration", async ({ expect }) => {
9961009
"logo_full_dark_mode_url": null,
9971010
"logo_full_url": null,
9981011
"logo_url": null,
1012+
"onboarding_status": "completed",
9991013
"owner_team_id": "<stripped UUID>",
10001014
},
10011015
"headers": Headers { <some fields may have been hidden> },
@@ -1065,6 +1079,7 @@ it("updates the project oauth configuration", async ({ expect }) => {
10651079
"logo_full_dark_mode_url": null,
10661080
"logo_full_url": null,
10671081
"logo_url": null,
1082+
"onboarding_status": "completed",
10681083
"owner_team_id": "<stripped UUID>",
10691084
},
10701085
"headers": Headers { <some fields may have been hidden> },
@@ -1134,6 +1149,7 @@ it("updates the project oauth configuration", async ({ expect }) => {
11341149
"logo_full_dark_mode_url": null,
11351150
"logo_full_url": null,
11361151
"logo_url": null,
1152+
"onboarding_status": "completed",
11371153
"owner_team_id": "<stripped UUID>",
11381154
},
11391155
"headers": Headers { <some fields may have been hidden> },

‎apps/e2e/tests/backend/endpoints/api/v1/team-permissions.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ it("can customize default team permissions", async ({ expect }) => {
261261
"logo_full_dark_mode_url": null,
262262
"logo_full_url": null,
263263
"logo_url": null,
264+
"onboarding_status": "completed",
264265
"owner_team_id": "<stripped UUID>",
265266
},
266267
"headers": Headers { <some fields may have been hidden> },

‎claude/CLAUDE-KNOWLEDGE.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,3 +93,6 @@ A: On `apps/dashboard/src/app/(main)/(protected)/(outside-dashboard)/new-project
9393

9494
Q: How should dashboard project onboarding status responses be handled to avoid silently bypassing onboarding?
9595
A: Import `ProjectOnboardingStatus`/`projectOnboardingStatusValues` from `@stackframe/stack-shared/dist/schema-fields`, validate every `onboarding_status` from `/internal/projects`, and throw on invalid/missing values instead of defaulting to `"completed"`.
96+
97+
Q: What E2E updates are required after adding `onboarding_status` to project API responses?
98+
A: Update affected inline snapshots in `apps/e2e/tests/backend/endpoints/api/v1/**` to include `"onboarding_status": "completed"` in project payloads (for example projects, permissions, and integration provisioning/current endpoints), otherwise CI setup/restart E2E jobs fail with snapshot mismatches.

0 commit comments

Comments
 (0)