refactor: payments dashboard consistency changes

Author: nams1570

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/payments/products/[productId]/edit/page-client.tsx

@@ -34,6 +34,7 @@ import { PricingSection } from "../../pricing-section";
 import { ProductCardPreview } from "../../product-card-preview";
 import {
   createFreePrice,
+  isFreePrices,
   type Price,
   type Product,
 } from "../../utils";
@@ -378,7 +379,7 @@ function EditProductForm({ productId, existingProduct }: { productId: string, ex
                 hasError={!!errors.prices}
                 errorMessage={errors.prices}
                 variant="form"
-                isFree={Object.keys(prices).length === 1 && Object.values(prices)[0].USD === '0.00'}
+                isFree={isFreePrices(prices)}
                 onMakeFree={() => {
                   setPrices(createFreePrice());
                 }}

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/payments/products/[productId]/page-client.tsx

@@ -59,7 +59,7 @@ import {
   priceToEditingPrice,
   type EditingPrice,
 } from "../price-edit-dialog";
-import { DEFAULT_INTERVAL_UNITS, generateUniqueId, intervalLabel, shortIntervalLabel, type Price, type Product } from "../utils";
+import { createFreePrice, DEFAULT_INTERVAL_UNITS, generateUniqueId, intervalLabel, isFreePrices, shortIntervalLabel, type Price, type Product } from "../utils";
 
 const CUSTOMER_TYPE_COLORS = {
   user: 'bg-blue-500/15 text-blue-600 dark:bg-blue-500/20 dark:text-blue-400 ring-blue-500/30',
@@ -878,11 +878,7 @@ function ProductPricesSection({ productId, prices, onPricesChange, inline = fals
   };
 
   const priceEntries = typedEntries(prices);
-  const isFree = priceEntries.length === 1
-    && (priceEntries[0][1].USD === '0' || priceEntries[0][1].USD === '0.00')
-    && !priceEntries[0][1].interval
-    && !priceEntries[0][1].freeTrial
-    && !priceEntries[0][1].serverOnly;
+  const isFree = isFreePrices(prices);
   const hasNoPrices = priceEntries.length === 0;
 
   const handleMakePaid = () => {
@@ -891,10 +887,7 @@ function ProductPricesSection({ productId, prices, onPricesChange, inline = fals
   };
 
   const handleMakeFree = () => {
-    const newPriceId = generateUniqueId('price');
-    onPricesChange({
-      [newPriceId]: { USD: '0', serverOnly: false },
-    });
+    onPricesChange(createFreePrice());
   };
 
   const listContent = (

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/payments/products/new/page-client.tsx

@@ -42,6 +42,7 @@ import { PricingSection } from "../pricing-section";
 import { ProductCardPreview } from "../product-card-preview";
 import {
   createFreePrice,
+  isFreePrices,
   type Price,
   type Product,
 } from "../utils";
@@ -786,7 +787,7 @@ ${Object.entries(prices).map(([id, price]) => {
                 hasError={!!errors.prices}
                 errorMessage={errors.prices}
                 variant="form"
-                isFree={Object.keys(prices).length === 1 && Object.values(prices)[0].USD === '0.00'}
+                isFree={isFreePrices(prices)}
                 onMakeFree={() => {
                   setPrices(createFreePrice());
                 }}

apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/payments/products/utils.ts

@@ -129,6 +129,26 @@ export function createFreePrice(): { [priceId: string]: Price } {
   return { [generateUniqueId('price')]: { USD: '0.00', serverOnly: false } };
 }
 
+/**
+ * Returns true if `prices` represents a "free" product: exactly one price entry
+ * whose USD amount is `'0'` or `'0.00'` and which has no interval, free-trial, or
+ * server-only flag set (any of those would change the semantics meaningfully).
+ *
+ * We accept both `'0'` and `'0.00'` for backward-compatibility with rows written
+ * before we standardized on `createFreePrice()` (which emits `'0.00'`). All three
+ * product pages (list, edit, create) call this so the "Free" indicator and the
+ * "Make free" / "Make paid" toggles stay in sync.
+ */
+export function isFreePrices(prices: PricesObject): boolean {
+  const entries = Object.values(prices);
+  if (entries.length !== 1) return false;
+  const [price] = entries;
+  return (price.USD === '0' || price.USD === '0.00')
+    && !price.interval
+    && !price.freeTrial
+    && !price.serverOnly;
+}
+
 // ============================================================================
 // ID Validation & Generation
 // ============================================================================