Commit 5b7f875
committed
fix(oauth): stop forcing prompt=consent on non-Google providers
The base OAuth provider hardcoded prompt=consent and access_type=offline
on every authorize URL. Both are Google-specific: prompt=consent caused
GitHub, Microsoft, Discord, GitLab, Apple, and X to re-show their
authorization screen on every sign-in, and access_type=offline was
silently ignored by every non-Google provider.
Move both params into Google's authorizationExtraParams so Google's
behavior is unchanged (refresh token still reliably issued via
prompt=consent + access_type=offline), and let other providers fall
back to standard OAuth behavior: consent only on first authorization,
new scopes, or after the user revokes the grant.
Update the Spotify e2e snapshot to drop the now-absent params.1 parent c01c052 commit 5b7f875
3 files changed
Lines changed: 3 additions & 4 deletions
File tree
- apps
- backend/src/oauth/providers
- e2e/tests/backend/endpoints/api/v1/auth/oauth
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
208 | | - | |
209 | 207 | | |
210 | 208 | | |
211 | 209 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
0 commit comments