refactor(tests): enhance project update logic and improve test reliability

- Added a condition to skip environment config overrides for metadata-only project updates in `createOrUpdateProjectWithLegacyConfig`.
- Replaced fixed wait times in internal metrics tests with a polling mechanism for better reliability in asynchronous data verification.
- Cleaned up the `failed-emails-digest` test by improving the structure and ensuring consistent snapshot expectations.
- Removed outdated test for non-existent config files in the local emulator project endpoint, as it is now handled by a different test case.

Author: mantrakp04

apps/backend/src/lib/projects.tsx

@@ -314,11 +314,13 @@ export async function createOrUpdateProjectWithLegacyConfig(
     configOverrideOverride['apps.installed.authentication.enabled'] ??= true;
     configOverrideOverride['apps.installed.emails.enabled'] ??= true;
   }
+  if (options.type === "create" || Object.keys(configOverrideOverride).length > 0) {
     await overrideEnvironmentConfigOverride({
       projectId: projectId,
       branchId: branchId,
       environmentConfigOverrideOverride: configOverrideOverride,
     });
+  }
   const result = await getProject(projectId);
   if (!result) {
     throw new StackAssertionError("Project not found after creation/update", { projectId });

apps/e2e/tests/backend/endpoints/api/v1/internal-metrics.test.ts

@@ -173,9 +173,7 @@ it("should return metrics data with users", async ({ expect }) => {
   backendContext.set({ mailbox: mailboxes[2], ipData: { country: "CH", ipAddress: "127.0.0.1", city: "Zurich", region: "ZH", latitude: 47.3769, longitude: 8.5417, tzIdentifier: "Europe/Zurich" } });
   await Auth.Otp.signIn();
 
-  await wait(3000);  // the event log is async, so let's give it some time to be written to the DB
-
-  const response = await niceBackendFetch("/api/v1/internal/metrics", { accessType: 'admin' });
+  const response = await waitForMetricsToIncludeUsersByCountry({ countryCode: "CH", expectedCount: 1 });
   expect(response).toMatchSnapshot(`metrics_result_with_users`);
 
   await ensureAnonymousUsersAreStillExcluded(response);

apps/e2e/tests/backend/endpoints/api/v1/internal/failed-emails-digest.test.ts

@@ -104,26 +104,26 @@ describe("with valid credentials", () => {
 
     await wait(10_000);
 
-      const response = await niceBackendFetch("/api/v1/internal/failed-emails-digest", {
-        method: "POST",
-        headers: { "Authorization": "Bearer mock_cron_secret" },
-        query: {
-          dry_run: `${isDryRun}`,
-        },
-      });
+    const response = await niceBackendFetch("/api/v1/internal/failed-emails-digest", {
+      method: "POST",
+      headers: { "Authorization": "Bearer mock_cron_secret" },
+      query: {
+        dry_run: `${isDryRun}`,
+      },
+    });
       expect(response.status).toBe(200);
 
       const failedEmailsByTenancy = response.body.failed_emails_by_tenancy;
-    const mockProjectFailedEmails = failedEmailsByTenancy.filter(
+      const mockProjectFailedEmails = failedEmailsByTenancy.filter(
         (batch: any) => batch.tenant_owner_emails.includes(backendContext.value.mailbox.emailAddress)
       ).map((batch: any) => ({
         ...batch,
         emails: [...batch.emails].sort((a, b) => stringCompare(a.subject, b.subject)),
       }));
 
-    if (process.env.STACK_TEST_SOURCE_OF_TRUTH === "true") {
+      if (process.env.STACK_TEST_SOURCE_OF_TRUTH === "true") {
       expect(mockProjectFailedEmails).toMatchInlineSnapshot(`[]`);
-    } else {
+      } else {
       expect(mockProjectFailedEmails).toMatchInlineSnapshot(`
         [
           {
@@ -147,11 +147,11 @@ describe("with valid credentials", () => {
         ]
       `);
       expect(mockProjectFailedEmails[0].project_id).toBe(projectId);
-    }
+      }
 
-    return {
-      projectOwnerMailbox,
-    };
+      return {
+        projectOwnerMailbox,
+      };
   }
 
   it("should return 200 and process dry run request", async ({ expect }) => {

apps/e2e/tests/backend/endpoints/api/v1/internal/local-emulator-project.test.ts

@@ -53,21 +53,6 @@ describe("local emulator project endpoint", () => {
     }
   });
 
-  it.runIf(isLocalEmulator)("rejects non-existent config files", async ({ expect }) => {
-    const nonExistentPath = `/tmp/${randomUUID()}/stack.config.ts`;
-
-    const response = await niceBackendFetch(LOCAL_EMULATOR_PROJECT_ENDPOINT, {
-      accessType: "admin",
-      method: "POST",
-      body: {
-        absolute_file_path: nonExistentPath,
-      },
-    });
-
-    expect(response.status).toBe(400);
-    expect(response.body).toContain("Config file not found");
-  });
-
   it.runIf(isLocalEmulator)("writes default config for empty files", async ({ expect }) => {
     const filePath = `/tmp/${randomUUID()}/stack.config.ts`;
     await fs.mkdir(path.dirname(filePath), { recursive: true });