Fix flaky ClickHouse test: add per-request timeout#1201
Closed
BilalG1 wants to merge 1 commit into
Closed
Conversation
If a single runQueryForCurrentProject call hangs (e.g. backend overloaded by parallel sync-engine webhooks), the inner polling timeout never fires because it only checks at the top of the while loop. This causes the test to hit the vitest timeout instead of retrying. Add a 30s per-request timeout via Promise.race in both waitForClickhouseUser and waitForClickhouseUserDeletion. If a request exceeds 30s, the loop continues polling instead of blocking.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promise.race) towaitForClickhouseUserandwaitForClickhouseUserDeletionin the ClickHouse sync testrunQueryForCurrentProjectcall hangs (backend overloaded by parallel sync-engine webhooks), the polling loop now continues instead of blocking until the vitest timeout firesTheory
niceFetchcallsfetch()with no timeout. If a single request hangs, the inner polling timeout never fires (it only checks at the top of thewhileloop). The test hits the vitest timeout instead.Test plan