Fix flaky ClickHouse test: reset claimed requests on QStash failure#1202
Closed
BilalG1 wants to merge 1 commit into
Closed
Fix flaky ClickHouse test: reset claimed requests on QStash failure#1202BilalG1 wants to merge 1 commit into
BilalG1 wants to merge 1 commit into
Conversation
When upstash.batchJSON() fails, the catch block captures the error but does NOT unclaim the requests — they stay stuck with startedFulfillingAt set. No new OutgoingRequest is created (dedup key conflict only checks NULL startedFulfillingAt). This can cause tests to deadlock waiting for a sync that never completes. Reset startedFulfillingAt to NULL in the catch block so requests can be re-claimed on the next poller iteration.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstash.batchJSON()fails in the poller's batch path, reset the claimedOutgoingRequestrows by settingstartedFulfillingAtback toNULLTheory
When the batch QStash call fails, the catch block captures the error but does NOT unclaim the requests. They're stuck with
startedFulfillingAt IS NOT NULL. No newOutgoingRequestis created (dedup key conflict only checks NULL). The test deadlocks: the first sync never completes, and the test waits forever.Test plan