Skip to content

Fix flaky ClickHouse test: reset claimed requests on QStash failure #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BilalG1 wants to merge 1 commit into from
Closed

Fix flaky ClickHouse test: reset claimed requests on QStash failure #1202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion apps/backend/src/app/api/latest/internal/external-db-sync/poller/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { OutgoingRequest } from "@/generated/prisma/client";
import { Prisma, type OutgoingRequest } from "@/generated/prisma/client";
import { getExternalDbSyncFusebox } from "@/lib/external-db-sync-metadata";
import { upstash } from "@/lib/upstash";
import { globalPrismaClient, retryTransaction } from "@/prisma-client";
Expand Down Expand Up @@ -219,6 +219,17 @@ export const GET = createSmartRouteHandler({
} catch (error) {
processSpan.setAttribute("stack.external-db-sync.iteration-error", true);
captureError("poller-iteration-error", error);
// Reset claimed requests so they can be retried on the next iteration
// instead of staying stuck with startedFulfillingAt set
try {
await globalPrismaClient.$executeRaw`
UPDATE "OutgoingRequest"
SET "startedFulfillingAt" = NULL
WHERE "id" IN (${Prisma.join(requests.map(r => r.id))})
`;
} catch (resetError) {
captureError("poller-reset-claimed-requests", resetError);
}
processSpan.setAttribute("stack.external-db-sync.processed-count", 0);
return 0;
}
Expand Down
Loading