Fix flaky ClickHouse test: use direct sync in CI#1203
Closed
BilalG1 wants to merge 1 commit into
Closed
Conversation
With STACK_EXTERNAL_DB_SYNC_DIRECT=false, all syncs go through QStash with parallelism: 20. The ~672 user creations across 79 parallel test files generate hundreds of sync requests that can saturate QStash, starving individual test tenancies. Set STACK_EXTERNAL_DB_SYNC_DIRECT=true in all 6 CI workflow files so the poller calls the sync-engine endpoint directly (via HTTP to the local backend) instead of going through QStash.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STACK_EXTERNAL_DB_SYNC_DIRECT: "true"in all 6 CI workflow filesTheory
With
STACK_EXTERNAL_DB_SYNC_DIRECT=false, all syncs go through QStash withparallelism: 20. The ~672 user creations across 79 parallel test files generate hundreds of sync requests that saturate QStash. Individual test tenancies get starved, causing timeouts.Test plan