Fix flaky ClickHouse test: add FINAL to metadata query#1204
Closed
BilalG1 wants to merge 1 commit into
Closed
Conversation
The _stack_sync_metadata table uses ReplacingMergeTree(updated_at). Without the FINAL keyword, unmerged rows can cause the query to return a stale high value via ORDER BY updated_at DESC LIMIT 1, causing the sync engine to skip data. Add FINAL to ensure ClickHouse deduplicates rows before returning the last_synced_sequence_id.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FINALkeyword to thegetClickhouseLastSyncedSequenceIdquery against the_stack_sync_metadatatableTheory
_stack_sync_metadatais aReplacingMergeTree(updated_at)table. Without theFINALkeyword, unmerged rows can causeORDER BY updated_at DESC LIMIT 1to return a stale high value, causing the sync engine to skip data. This could make the test wait forever for data that was already "synced" according to a stale metadata row.Test plan