Get MSVC builds working on x86_64; add MSVC build targets that link the dynamic MSVC runtime#12
Open
DouglasDwyer wants to merge 8 commits intohexops-graveyard:mainfrom
Open
Get MSVC builds working on x86_64; add MSVC build targets that link the dynamic MSVC runtime#12DouglasDwyer wants to merge 8 commits intohexops-graveyard:mainfrom
DouglasDwyer wants to merge 8 commits intohexops-graveyard:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the changes from #8 alongside some additional fixes. With these fixes, I am able to build the
windows-msvctarget on my machine.In addition, this PR adds a new compilation flag (
-Dmsvcrt_dynamic) that allows for linking the dynamic MSVC runtime (msvcrt.lib) rather than the static one (libcmt.lib). This is useful if you want to includemachdxcompiler.libin a project that already has other libraries linking tomsvcrt.lib. I have also added CI builds that run with this flag enabled.(Note: for easy proof that this is working, you can check out the CI builds on my fork of the project. The
msvctargets for x86_64 now build!)