Set finite OnceCache timeout for OAuth token exchange and refresh#1142
Merged
Conversation
Waiters on Hex.OnceCache shared a hardcoded 5s default timeout while the underlying HTTP call can take up to 15s. Under concurrent private package fetches in :hex_fetcher this caused all but the computing task to time out before the token exchange completed. Use a 60s timeout consistent with Hex.Registry.Server and other HTTP-bound GenServer calls in the codebase. Replace the :infinity timeout in Hex.OAuth with the same bound; the interactive device flow is invoked sequentially from check_and_refresh_auth before parallel fetches begin, so concurrent waiters only ever cover the HTTP refresh path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiters on Hex.OnceCache shared a hardcoded 5s default timeout while the underlying HTTP call can take up to 15s. Under concurrent private package fetches in :hex_fetcher this caused all but the computing task to time out before the token exchange completed.
Use a 60s timeout consistent with Hex.Registry.Server and other HTTP-bound GenServer calls in the codebase. Replace the :infinity timeout in Hex.OAuth with the same bound; the interactive device flow is invoked sequentially from check_and_refresh_auth before parallel fetches begin, so concurrent waiters only ever cover the HTTP refresh path.
Closes #1141.