Skip to content

Loosen API key format assertion to is_binary + byte_size > 0 #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericmj merged 1 commit into from
May 9, 2026
Merged

Loosen API key format assertion to is_binary + byte_size > 0 #1151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/hex/api_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ defmodule Hex.APITest do

assert {:ok, {201, _, %{"secret" => key_a}}} = Hex.API.Key.new("key_a", permissions, auth)
assert {:ok, {201, _, %{"secret" => key_b}}} = Hex.API.Key.new("key_b", permissions, auth)
assert byte_size(key_a) == 32
assert byte_size(key_b) == 32
assert is_binary(key_a) and byte_size(key_a) > 0
assert is_binary(key_b) and byte_size(key_b) > 0
auth = [key: key_a]

Hexpm.new_package("hexpm", "melon", "0.0.1", %{}, %{}, auth)
Expand All @@ -91,8 +91,8 @@ defmodule Hex.APITest do
auth = [user: "user", pass: "hunter42"]
assert {:ok, {201, _, %{"secret" => key_c}}} = Hex.API.Key.new("key_c", permissions, auth)
assert {:ok, {201, _, %{"secret" => key_d}}} = Hex.API.Key.new("key_d", permissions, auth)
assert byte_size(key_c) == 32
assert byte_size(key_d) == 32
assert is_binary(key_c) and byte_size(key_c) > 0
assert is_binary(key_d) and byte_size(key_d) > 0
auth_c = [key: key_c]
auth_d = [key: key_d]

Expand Down
Loading