Replace hex_erl_tar fork with OTP master's erl_tar#165
Merged
Conversation
Copy erl_tar.erl and erl_tar.hrl from OTP commit 013041bd68c2 with
minimal modifications (module rename, include path, remove -doc/-moduledoc
attributes for OTP 24 compatibility).
This eliminates divergence from upstream. The fork's add/5 is replaced
with OTP's add/4 using the {mode, Mode} option. hex_filename.erl is
removed since filelib:safe_relative_path/2 is available since OTP 23.
Join symlink targets with the symlink's parent directory before validating. Previously the raw target was validated in isolation, causing safe symlinks like dir/link -> ../file to be incorrectly rejected as unsafe.
Member
Author
|
See erlang/otp#10814 for the backport of "Fix erl_tar rejecting safe symlinks with .. in target" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy erl_tar.erl and erl_tar.hrl from OTP commit 013041bd68c2 with
minimal modifications (module rename, include path, remove -doc/-moduledoc
attributes for OTP 24 compatibility).
This eliminates divergence from upstream. The fork's add/5 is replaced
with OTP's add/4 using the {mode, Mode} option. hex_filename.erl is
removed since filelib:safe_relative_path/2 is available since OTP 23.