cli: namespace CLI-originated download/encode error codes with cli_ prefix

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: somanshreddy

cmd/heygen/video_download.go

@@ -105,7 +105,7 @@ func newVideoDownloadCmd(ctx *cmdContext) *cobra.Command {
 			})
 			if err != nil {
 				return &clierrors.CLIError{
-					Code:     "internal_error",
+					Code:     "cli_response_encode_error",
 					Message:  fmt.Sprintf("failed to encode response: %v", err),
 					Hint:     "Please report this CLI bug with the command you ran.",
 					ExitCode: clierrors.ExitGeneral,
@@ -128,7 +128,7 @@ func extractAssetURL(raw json.RawMessage, videoID string, info assetInfo) (strin
 	}
 	if err := json.Unmarshal(raw, &resp); err != nil {
 		return "", &clierrors.CLIError{
-			Code:     "response_parse_error",
+			Code:     "cli_response_parse_error",
 			Message:  "failed to parse the video response",
 			Hint:     "The API response could not be parsed. Retry; if it persists, report it (possible CLI/API mismatch).",
 			ExitCode: clierrors.ExitGeneral,
@@ -191,7 +191,7 @@ func downloadFile(ctx context.Context, videoURL, dest string) error {
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, videoURL, nil)
 	if err != nil {
 		return &clierrors.CLIError{
-			Code:     "response_parse_error",
+			Code:     "cli_response_parse_error",
 			Message:  fmt.Sprintf("the download URL returned by the API is unusable: %v", err),
 			Hint:     "Re-fetch a fresh URL: heygen video get <video_id>",
 			ExitCode: clierrors.ExitGeneral,
@@ -214,14 +214,14 @@ func downloadFile(ctx context.Context, videoURL, dest string) error {
 		// re-fetch); any other status is the asset host (our storage/CDN) failing.
 		if resp.StatusCode == http.StatusForbidden || resp.StatusCode == http.StatusNotFound {
 			return &clierrors.CLIError{
-				Code:     "download_url_expired",
+				Code:     "cli_download_url_expired",
 				Message:  fmt.Sprintf("download link expired or unavailable (HTTP %d)", resp.StatusCode),
 				Hint:     "This download link has expired. Re-fetch a fresh URL: heygen video get <video_id>",
 				ExitCode: clierrors.ExitGeneral,
 			}
 		}
 		return &clierrors.CLIError{
-			Code:     "asset_download_failed",
+			Code:     "cli_download_failed",
 			Message:  fmt.Sprintf("download failed with HTTP %d", resp.StatusCode),
 			Hint:     "The asset host returned an error fetching the file. This is usually transient — retry shortly.",
 			ExitCode: clierrors.ExitGeneral,
@@ -234,7 +234,7 @@ func downloadFile(ctx context.Context, videoURL, dest string) error {
 	tmp, err := os.CreateTemp(dir, ".heygen-download-*.tmp")
 	if err != nil {
 		return &clierrors.CLIError{
-			Code:     "file_io_error",
+			Code:     "cli_file_io_error",
 			Message:  fmt.Sprintf("failed to create temp file in %q: %v", dir, err),
 			Hint:     "Could not write locally. Check the destination path and free disk space.",
 			ExitCode: clierrors.ExitGeneral,
@@ -247,7 +247,7 @@ func downloadFile(ctx context.Context, videoURL, dest string) error {
 	if copyErr != nil {
 		_ = os.Remove(tmpPath)
 		return &clierrors.CLIError{
-			Code:     "download_interrupted",
+			Code:     "cli_download_interrupted",
 			Message:  fmt.Sprintf("download interrupted: %v", copyErr),
 			Hint:     "The transfer was cut off. Retry; the partial file was cleaned up.",
 			ExitCode: clierrors.ExitGeneral,
@@ -256,7 +256,7 @@ func downloadFile(ctx context.Context, videoURL, dest string) error {
 	if closeErr != nil {
 		_ = os.Remove(tmpPath)
 		return &clierrors.CLIError{
-			Code:     "file_io_error",
+			Code:     "cli_file_io_error",
 			Message:  fmt.Sprintf("failed to finalize download: %v", closeErr),
 			Hint:     "Could not finalize the file locally. Check free disk space.",
 			ExitCode: clierrors.ExitGeneral,
@@ -269,7 +269,7 @@ func downloadFile(ctx context.Context, videoURL, dest string) error {
 	if err := os.Rename(tmpPath, dest); err != nil {
 		_ = os.Remove(tmpPath)
 		return &clierrors.CLIError{
-			Code:     "file_io_error",
+			Code:     "cli_file_io_error",
 			Message:  fmt.Sprintf("failed to move download to %q: %v", dest, err),
 			Hint:     "Could not write to the destination path. Check permissions and free disk space.",
 			ExitCode: clierrors.ExitGeneral,

cmd/heygen/video_download_test.go

@@ -406,16 +406,16 @@ func TestVideoDownload_DownloadFails(t *testing.T) {
 	if res.ExitCode != 1 {
 		t.Fatalf("ExitCode = %d, want 1\nstderr: %s", res.ExitCode, res.Stderr)
 	}
-	if !strings.Contains(res.Stderr, `"code":"asset_download_failed"`) {
-		t.Fatalf("stderr should carry asset_download_failed (asset-host 5xx):\n%s", res.Stderr)
+	if !strings.Contains(res.Stderr, `"code":"cli_download_failed"`) {
+		t.Fatalf("stderr should carry cli_download_failed (asset-host 5xx):\n%s", res.Stderr)
 	}
 	if _, err := os.Stat(dest); !os.IsNotExist(err) {
 		t.Fatalf("expected no output file, stat err = %v", err)
 	}
 }
 
 // A presigned asset URL that 403s or 404s is expired/revoked — a client-side
-// download_url_expired, distinct from the asset host failing (asset_download_failed).
+// cli_download_url_expired, distinct from the asset host failing (cli_download_failed).
 func TestVideoDownload_ExpiredURL(t *testing.T) {
 	for _, status := range []int{http.StatusForbidden, http.StatusNotFound} {
 		t.Run(fmt.Sprintf("HTTP_%d", status), func(t *testing.T) {
@@ -444,8 +444,8 @@ func TestVideoDownload_ExpiredURL(t *testing.T) {
 			if res.ExitCode != 1 {
 				t.Fatalf("ExitCode = %d, want 1\nstderr: %s", res.ExitCode, res.Stderr)
 			}
-			if !strings.Contains(res.Stderr, `"code":"download_url_expired"`) {
-				t.Fatalf("stderr should carry download_url_expired (HTTP %d on presigned URL):\n%s", status, res.Stderr)
+			if !strings.Contains(res.Stderr, `"code":"cli_download_url_expired"`) {
+				t.Fatalf("stderr should carry cli_download_url_expired (HTTP %d on presigned URL):\n%s", status, res.Stderr)
 			}
 			if !strings.Contains(res.Stderr, "video get") {
 				t.Fatalf("expired-URL hint should point to re-fetching via video get:\n%s", res.Stderr)
@@ -455,7 +455,7 @@ func TestVideoDownload_ExpiredURL(t *testing.T) {
 }
 
 // The video-get response failing to parse, or yielding an unusable download URL,
-// classifies as response_parse_error (not the opaque error code).
+// classifies as cli_response_parse_error (not the opaque error code).
 func TestVideoDownload_ResponseParseError(t *testing.T) {
 	t.Run("malformed video-get JSON", func(t *testing.T) {
 		dest := filepath.Join(t.TempDir(), "x.mp4")
@@ -473,8 +473,8 @@ func TestVideoDownload_ResponseParseError(t *testing.T) {
 		if res.ExitCode != 1 {
 			t.Fatalf("ExitCode = %d, want 1\nstderr: %s", res.ExitCode, res.Stderr)
 		}
-		if !strings.Contains(res.Stderr, `"code":"response_parse_error"`) {
-			t.Fatalf("stderr should carry response_parse_error:\n%s", res.Stderr)
+		if !strings.Contains(res.Stderr, `"code":"cli_response_parse_error"`) {
+			t.Fatalf("stderr should carry cli_response_parse_error:\n%s", res.Stderr)
 		}
 	})
 
@@ -495,8 +495,8 @@ func TestVideoDownload_ResponseParseError(t *testing.T) {
 		if res.ExitCode != 1 {
 			t.Fatalf("ExitCode = %d, want 1\nstderr: %s", res.ExitCode, res.Stderr)
 		}
-		if !strings.Contains(res.Stderr, `"code":"response_parse_error"`) {
-			t.Fatalf("stderr should carry response_parse_error for an unusable URL:\n%s", res.Stderr)
+		if !strings.Contains(res.Stderr, `"code":"cli_response_parse_error"`) {
+			t.Fatalf("stderr should carry cli_response_parse_error for an unusable URL:\n%s", res.Stderr)
 		}
 	})
 }