Commit 4d647da
fix(studio): document SELF_WRITE_SUPPRESS_MS heuristic; fix pre-existing TS errors
Reviewer noted the 2 s suppress window is a footgun. Add a comment explaining
the trade-off (short = echo fires anyway; long = masks real edits) and naming
the long-term fix (sequence number / content hash on the persist event).
Also fix three pre-existing issues in useDomEditCommits.ts on this branch:
- PatchOperation was used in UseDomEditCommitsParams but not imported
- onTrySdkPersist was called in persistDomEditOperations but missing from
both the interface and the function's destructure pattern
- onTrySdkPersist missing from useCallback deps (react-hooks/exhaustive-deps)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>1 parent 1e0035b commit 4d647da
2 files changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
80 | 88 | | |
81 | 89 | | |
82 | 90 | | |
| |||
98 | 106 | | |
99 | 107 | | |
100 | 108 | | |
| 109 | + | |
101 | 110 | | |
102 | 111 | | |
103 | 112 | | |
| |||
237 | 246 | | |
238 | 247 | | |
239 | 248 | | |
| 249 | + | |
240 | 250 | | |
241 | 251 | | |
242 | 252 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
31 | 37 | | |
32 | 38 | | |
33 | 39 | | |
| |||
0 commit comments