Commit 6d37ceb
fix(studio): use Context.Provider for React 18 and break iframe ref update loop
The #748 decomposition used `<Context value={}>` (React 19 syntax) but the
runtime is React 18.3.1, which requires `<Context.Provider value={}>`. This
caused all 4 context providers to silently fail to provide values.
Also fixes an infinite update loop between handlePreviewIframeRef and
NLELayout's onIframeRef effect — the callback identity change triggered the
effect which re-called the callback, creating a render loop visible as
"Maximum update depth exceeded" in dev mode and intermittent flickering in
production.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 2f7fcbf commit 6d37ceb
6 files changed
Lines changed: 9 additions & 6 deletions
File tree
- packages/studio/src
- components/nle
- contexts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
| 264 | + | |
264 | 265 | | |
265 | 266 | | |
266 | 267 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| 237 | + | |
| 238 | + | |
237 | 239 | | |
238 | | - | |
239 | | - | |
| 240 | + | |
| 241 | + | |
240 | 242 | | |
241 | 243 | | |
242 | 244 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
| 136 | + | |
137 | 137 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
| 134 | + | |
135 | 135 | | |
0 commit comments