fix(core): remove data-position-mode gate — clip-relative offsets apply unconditionally

miguel-heygen · Miguel07Alm · miguel-heygen · commit 6f9ff6965950 · 2026-06-14T18:53:25.000-04:00
Co-authored-by: Miguel Ángel &lt;miguel07alm@protonmail.com&gt;
diff --git a/packages/core/src/generators/hyperframes.ts b/packages/core/src/generators/hyperframes.ts
@@ -354,7 +354,7 @@ export function generateHyperframesHtml(
   const gsapCdnTag = includeScripts ? `  <script src="${GSAP_CDN}"></script>` : "";
 
   const gsapScriptTag = includeScripts
-    ? `  <script data-position-mode="relative">
+    ? `  <script>
 ${gsapScript}
   </script>`
     : "";
diff --git a/packages/core/src/runtime/init.ts b/packages/core/src/runtime/init.ts
@@ -988,7 +988,6 @@ export function initSandboxRuntimeModular(): void {
   };
 
   const applyClipRelativeOffsets = (timeline: RuntimeTimelineLike) => {
-    if (!document.querySelector("script[data-position-mode='relative']")) return;
     try {
       applyOffsets(timeline as never, (el) => resolveStartForElement(el, 0));
     } catch (err) {
diff --git a/packages/core/src/studio-api/routes/files.test.ts b/packages/core/src/studio-api/routes/files.test.ts
@@ -542,54 +542,4 @@ const tl = gsap.timeline();
     // The variable target was not flattened to a string-literal selector
     expect(result.after).toContain("tl.to(kicker,");
   });
-
-  it("stamps data-position-mode='relative' on the script tag after any mutation", async () => {
-    const projectDir = createProjectDir();
-    const html = `<!DOCTYPE html><html><body>
-<div id="hero" data-start="0" data-duration="4"></div>
-<script>
-const tl = gsap.timeline();
-tl.to("#hero", { x: 100, duration: 2 }, 0);
-</script></body></html>`;
-    writeHtml(projectDir, "index.html", html);
-    const app = new Hono();
-    registerFileRoutes(app, createAdapter(projectDir));
-
-    const anim = await getFirstAnimation(app, "index.html");
-    const res = await app.request("http://localhost/projects/demo/gsap-mutations/index.html", {
-      method: "POST",
-      headers: { "Content-Type": "application/json" },
-      body: JSON.stringify({ type: "update-meta", animationId: anim.id, updates: { position: 1 } }),
-    });
-    const result = (await res.json()) as { ok: boolean; after: string };
-
-    expect(res.status).toBe(200);
-    expect(result.ok).toBe(true);
-    expect(result.after).toContain('data-position-mode="relative"');
-  });
-
-  it("does not duplicate data-position-mode on subsequent mutations", async () => {
-    const projectDir = createProjectDir();
-    const html = `<!DOCTYPE html><html><body>
-<div id="hero" data-start="0" data-duration="4"></div>
-<script data-position-mode="relative">
-const tl = gsap.timeline();
-tl.to("#hero", { x: 100, duration: 2 }, 0);
-</script></body></html>`;
-    writeHtml(projectDir, "index.html", html);
-    const app = new Hono();
-    registerFileRoutes(app, createAdapter(projectDir));
-
-    const anim = await getFirstAnimation(app, "index.html");
-    const res = await app.request("http://localhost/projects/demo/gsap-mutations/index.html", {
-      method: "POST",
-      headers: { "Content-Type": "application/json" },
-      body: JSON.stringify({ type: "update-meta", animationId: anim.id, updates: { position: 1 } }),
-    });
-    const result = (await res.json()) as { ok: boolean; after: string };
-
-    expect(res.status).toBe(200);
-    const matches = result.after.match(/data-position-mode/g);
-    expect(matches).toHaveLength(1);
-  });
 });
diff --git a/packages/core/src/studio-api/routes/files.ts b/packages/core/src/studio-api/routes/files.ts
@@ -1178,9 +1178,6 @@ export function registerFileRoutes(api: Hono, adapter: StudioApiAdapter): void {
 
     const newScript = typeof result === "string" ? result : result.script;
     const changed = newScript !== block.scriptText;
-    if (changed && !block.scriptElement.hasAttribute("data-position-mode")) {
-      block.scriptElement.setAttribute("data-position-mode", "relative");
-    }
     const newHtml = changed ? block.replaceScript(newScript) : html;
     let backupPath: string | null = null;
     if (changed) {
