Skip to content

Commit c9d5fe6

Browse files
jrusso1020claude
andcommitted
refactor(producer): apply /simplify findings on variables-prod
Align the no-op timeline duration with the root's data-duration. The fixture's root has data-duration="3" but the placeholder timeline tween was still { duration: 2 } — leftover from when I bumped the duration from 2s to 3s to dodge the PSNR-checkpoint-at-1.99s parse edge case. The tween is a no-op (no targets, no visible effect) so rendered pixels don't change; baseline still passes Docker regression at 100/100 checkpoints. Reuse + efficiency reviews otherwise clean. Two findings deferred: silence.wav duplication is real but only 2 fixtures share it today — worth extracting to tests/_shared/ when the third fixture lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 58b4234 commit c9d5fe6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • packages/producer/tests/variables-prod/src

packages/producer/tests/variables-prod/src/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ <h1 id="title-el" class="title clip" data-start="0" data-duration="3"></h1>
8989
const tl = gsap.timeline({ paused: true });
9090
// Static placement — no animation. Keeps the regression frame-stable
9191
// and isolates "did the variables flow through?" from motion concerns.
92-
tl.to({}, { duration: 2 });
92+
tl.to({}, { duration: 3 });
9393
window.__timelines["main"] = tl;
9494
</script>
9595
</body>

0 commit comments

Comments
 (0)