Commit d8190d7
ci(regression): add webm-vp9 to shard-3 + fix harness doc count
Three follow-ups bundled together (Vai's review feedback on PR #952
plus the fallow audit findings that surfaced when committing them):
1. **Wire webm-vp9 into CI regression.** The fixture was added in this
PR but never appeared in any `.github/workflows/regression.yml`
shard's args allowlist, so the regression harness's positional-args
gate skipped it in CI. Append `webm-vp9` to shard-3 (which already
carries `mp4-h264-sdr` + `webm-transparency`) so the fixture runs.
2. **Fix stale "four hard gates" prose in checkDistributedSupport
docstring.** Earlier in the stack I removed the webm bullet but
didn't update the count. Two gates remain (fps + hdr).
3. **Suppress fallow complexity finding on `formatExtension`.**
Adding the webm case tipped the function's CRAP score from 4
(passing) to 5 (= threshold 30.0), tripping the pre-commit audit.
The function is an exhaustive switch dispatch over a closed-set
enum: each case is a literal `return`, and the `default` arm's
`_exhaustive: never` assertion is load-bearing for future format
additions. Marked with `fallow-ignore-next-line complexity` per
the tool's own suggested suppression placement. Investigation log:
- Fallow's "32 above threshold" output bundles all findings in
changed files (including 31 inherited). Verdict math is correct.
- JSON output confirmed `complexity_introduced: 1` →
`formatExtension` was the lone new finding.
- With the suppression in place: `complexity_introduced: 0`,
verdict `warn`, exit 0 on `--fail-on-issues`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent df2a67e commit d8190d7
3 files changed
Lines changed: 8 additions & 2 deletions
File tree
- .github/workflows
- packages
- aws-lambda/src
- producer/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
11 | 17 | | |
12 | 18 | | |
13 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
0 commit comments