Skip to content

feat(core): expose hf-ids as subpath export for @hyperframes/sdk#1323

Merged
vanceingalls merged 1 commit into
mainfrom
06-10-feat_core_expose_hf-ids_as_subpath_export_for_hyperframes_sdk
Jun 11, 2026
Merged

feat(core): expose hf-ids as subpath export for @hyperframes/sdk#1323
vanceingalls merged 1 commit into
mainfrom
06-10-feat_core_expose_hf-ids_as_subpath_export_for_hyperframes_sdk

Conversation

@vanceingalls

@vanceingalls vanceingalls commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Exposes hf-ids as a dedicated subpath export from @hyperframes/core so @hyperframes/sdk can import ID-stamping logic without pulling in the full core bundle.

  • Adds "exports" entry for ./hf-ids in packages/core/package.json
  • No change to the existing top-level export — no breaking change for existing consumers

Why

@hyperframes/sdk needs parseMutable/stampHfIds from core. A subpath export isolates that boundary and keeps the SDK bundle lean.

Test plan

  • bun run build — both packages build without errors
  • bun test packages/sdk — import resolves correctly

🤖 Generated with Claude Code

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal change. The subpath export is correctly placed in both the dev (src/) and dist (publishConfig.exports) conditions, consistent with the pattern used by ./gsap-parser and ./runtime/mediaVolumeEnvelope. No issues.

@james-russo-rames-d-jusso james-russo-rames-d-jusso left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick approve from my side. Two new entries in packages/core/package.json exports (one src-mode for dev workspace consumers, one publish-mode for the dist build) pointing @hyperframes/core/hf-ids at the existing parsers/hfIds.ts module.

Verified:

  • packages/core/src/parsers/hfIds.ts exists at this SHA and exposes the expected surface (mintHfId, ensureHfIds).
  • Both exports symmetrically defined under exports. and publishConfig.exports. — no risk of dev-mode + publish-mode drift.
  • Alphabetic ordering within the exports map is preserved (sits between mediaVolumeEnvelope and gsap-parser).
  • The subpath name hf-ids (hyphen) follows the existing convention for kebab-case subpaths (gsap-parser, dom-edit, etc.). Internal file is hfIds.ts (camelCase) — fine, file naming and subpath naming are independent contracts.

The SDK consumer in #1324 (packages/sdk/src/document.ts:12) actually uses this import — confirmed it resolves correctly through the workspace.

Trivial enabler. LGTM.

Review by Rames D Jusso

@vanceingalls vanceingalls force-pushed the 06-10-feat_core_expose_hf-ids_as_subpath_export_for_hyperframes_sdk branch from 0c5614f to 865aa69 Compare June 11, 2026 08:02
@vanceingalls vanceingalls merged commit 2c64f99 into main Jun 11, 2026
63 checks passed
@vanceingalls vanceingalls deleted the 06-10-feat_core_expose_hf-ids_as_subpath_export_for_hyperframes_sdk branch June 11, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants