fix(studio): surface save failures when deleting all animations for an element

[calcarazgre646]

Problem

deleteAllForSelector in useGsapScriptCommits fired its mutation with void commitMutation(...):

void commitMutation(
  selection,
  { type: "delete-all-for-selector", targetSelector },
  { label: "Delete all animations for element" },
);

A failed "Delete all animations for element" was therefore swallowed — no error toast and no trackGsapSaveFailure telemetry — leaving the user believing the operation succeeded. Every sibling mutation in the hook (deleteGsapAnimation, removeGsapProperty, removeAllKeyframes, updateGsapProperty, …) routes through commitMutationSafely, which .catches the rejection, records trackGsapSaveFailure, and shows an error toast. This one handler was the only mutation that did not.

Fix

Route deleteAllForSelector through commitMutationSafely, matching its siblings. It is a single user action (one context-menu invocation per element), so the failure toast fires at most once — no spam.

Notes

• Swept the hook and the rest of studio/src for the same fire-and-forget pattern: this was the only user-facing mutation that surfaced nothing. The remaining bare commitMutation calls either return the promise for the caller to handle or have their own .catch(trackGsapSaveFailure).
• No test added: there is no existing render harness for this hook, and the change is a one-line routing fix to the already-used commitMutationSafely wrapper that ~10 sibling handlers rely on.

[miguel-heygen]

Closing — the function this PR claims to fix (deleteAllForSelector), the wrapper it routes through (commitMutationSafely), and the telemetry it references (trackGsapSaveFailure) do not exist anywhere in the codebase and never have (confirmed via git history search). Every sibling mutation uses void commitMutation(...) — the exact pattern the PR describes as the bug. This would cause a build failure if merged.

Happy to reopen if evidence of the issue is provided.

[calcarazgre646]

Thanks for the careful look, and for the reopen offer. I think the review checkout may have been a bit behind #1366 — useSafeGsapCommitMutation (which provides commitMutationSafely + trackGsapSaveFailure) landed there (merged 2026-06-13 02:02 UTC). On current main:

• useGsapScriptCommits.ts:219 — const commitMutationSafely = useSafeGsapCommitMutation(commitMutation, trackGsapSaveFailure, showToast)
• :278 deleteGsapAnimation already routes through commitMutationSafely; :288 deleteAllForSelector is the one handler still on bare void commitMutation.
• useSafeGsapCommitMutation.ts defines both.

git grep -n commitMutationSafely packages/studio/src/hooks returns both files. I rebased this branch on current main and tsc --noEmit passes, so it shouldn't break the build. Happy to re-push the rebase if that makes it easier to re-check.