refactor(producer): centralize frame filenames and consolidate timing#1420
Closed
miguel-heygen wants to merge 3 commits into
Closed
refactor(producer): centralize frame filenames and consolidate timing#1420miguel-heygen wants to merge 3 commits into
miguel-heygen wants to merge 3 commits into
Conversation
Replace 4 inline padStart(6) template literals with shared helpers: - formatCaptureFrameName(index, ext): zero-based, for internal capture - formatExportFrameName(index, ext): zero-based input, one-based output for user-facing png-sequence export
Move fullStacking.map() from inside the per-layer iteration to before the loop, computing the element ID list once per frame instead of once per DOM layer per frame.
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 13, 2026
miguel-heygen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three pattern consolidation changes:
formatCaptureFrameName/formatExportFrameNamehelpers, replacing 4 inlinepadStart(6)sitesallElementIdsout of the per-layer compositing loop (perf: 1 map call instead of N per frame)timeHdrPhase/timeHdrPhaseAsyncwrappers tohdrPerf.ts, replacing ~28 boilerplate timing blocks448 LOC (251 insertions, 197 deletions)
Stack: 4/5