Skip to content

工单部分接口调用合并至api#1897

Draft
hhyo wants to merge 11 commits into
masterfrom
sql-wofkflow-api
Draft

工单部分接口调用合并至api#1897
hhyo wants to merge 11 commits into
masterfrom
sql-wofkflow-api

Conversation

@hhyo
Copy link
Copy Markdown
Owner

@hhyo hhyo commented Oct 7, 2022

  • 升级部分基础依赖(未完全测试)
  • 调整api项目的目录结构
  • 部分工单接口转移至api,版本为v2

@hhyo hhyo force-pushed the sql-wofkflow-api branch from c10f651 to 687464b Compare October 7, 2022 15:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2022

Codecov Report

❌ Patch coverage is 61.18980% with 137 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.05%. Comparing base (90fc156) to head (519e357).
⚠️ Report is 135 commits behind head on master.

Files with missing lines Patch % Lines
sql_api/serializers/sql_workflow.py 54.48% 71 Missing ⚠️
sql_api/api_views/sql_workflow.py 60.57% 41 Missing ⚠️
sql_api/permissions/sql_workflow.py 43.90% 23 Missing ⚠️
sql_api/serializers/__init__.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   76.34%   76.05%   -0.30%     
==========================================
  Files         115      119       +4     
  Lines       15852    15862      +10     
==========================================
- Hits        12103    12064      -39     
- Misses       3749     3798      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hhyo hhyo force-pushed the sql-wofkflow-api branch 2 times, most recently from e7d2cec to cf186c6 Compare October 22, 2022 15:00
@hhyo hhyo force-pushed the sql-wofkflow-api branch 2 times, most recently from b69ccc8 to a107ec6 Compare March 31, 2023 16:35
@hhyo hhyo force-pushed the sql-wofkflow-api branch from 6b463e5 to 0d1935b Compare April 7, 2023 14:50
@hhyo hhyo force-pushed the sql-wofkflow-api branch from 0d1935b to dcc754a Compare June 18, 2023 10:06
@hhyo hhyo force-pushed the sql-wofkflow-api branch 2 times, most recently from 3ce6ab8 to 6f6a816 Compare November 25, 2023 09:37
Comment thread sql/notify.py
from sql.utils.resource_group import auth_group_users
from sql.utils.workflow_audit import Audit
from sql_api.serializers import (
from sql_api.serializers.serializers import (
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在 serializers/__init__.py 里面 from .sql_workflow import xxxx

这样之前 import 的不用改, 这个路径也不会显得很奇怪, 你觉得如何

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants