Skip to content

test: test stable react vendor chunk#940

Closed
hi-ogawa wants to merge 3 commits into
mainfrom
06-12-test_test_stable_react_vendor_chunk
Closed

test: test stable react vendor chunk#940
hi-ogawa wants to merge 3 commits into
mainfrom
06-12-test_test_stable_react_vendor_chunk

Conversation

@hi-ogawa
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown
Owner Author

hi-ogawa commented Jun 12, 2025

@hi-ogawa hi-ogawa changed the base branch from 05-09-chore_react_vendor_chunk_in_example to graphite-base/940 June 12, 2025 07:26
hi-ogawa added a commit that referenced this pull request Jun 12, 2025
Just curiosity. I was wondering what would be a Vite equivalent of https://github.com/web-infra-dev/rsbuild/blob/main/packages/plugin-react/src/splitChunks.ts

Testing `manualChunks` is postponed for #940 for now since that's going to be tricky for rolldown-vite ci.
@hi-ogawa hi-ogawa force-pushed the 06-12-test_test_stable_react_vendor_chunk branch from 146e641 to 807fa3a Compare June 12, 2025 07:32
@hi-ogawa hi-ogawa force-pushed the graphite-base/940 branch from 2eab0c8 to 4c3b548 Compare June 12, 2025 07:32
@hi-ogawa hi-ogawa changed the base branch from graphite-base/940 to main June 12, 2025 07:32
@hi-ogawa hi-ogawa force-pushed the 06-12-test_test_stable_react_vendor_chunk branch from 807fa3a to 273aee6 Compare June 12, 2025 07:33
@hi-ogawa
Copy link
Copy Markdown
Owner Author

hi-ogawa commented Jun 23, 2025

Let's merge if the compat is added to rolldown (i.e. test passes without advancedChunks).

@hi-ogawa hi-ogawa force-pushed the 06-12-test_test_stable_react_vendor_chunk branch 3 times, most recently from 0a889a1 to 6832a08 Compare June 30, 2025 06:07
@hi-ogawa hi-ogawa force-pushed the 06-12-test_test_stable_react_vendor_chunk branch from 6832a08 to f9357e7 Compare July 3, 2025 02:09
hi-ogawa added a commit that referenced this pull request Jul 3, 2025
Just noticed `dist/client/.vite/manifest.json` is overwritten by `dist/rsc/.vite/manifest.json` when debugging #940.
@hi-ogawa
Copy link
Copy Markdown
Owner Author

hi-ogawa commented Jul 6, 2025

Superseded by vitejs/vite-plugin-react#532

@hi-ogawa hi-ogawa closed this Jul 6, 2025
@hi-ogawa hi-ogawa deleted the 06-12-test_test_stable_react_vendor_chunk branch July 6, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant