Resolve AnnotationBasedGenerator type argument through class hierarchy#12871
Merged
Conversation
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
beikov
approved these changes
Jun 23, 2026
stewue
force-pushed
the
main
branch
2 times, most recently
from
June 29, 2026 05:10
2dff0b0 to
383ddf8
Compare
Contributor
Author
|
@beikov I've addressed the points from your comment. Is there anything I need to do on my end (Jenkins CI is "in progress" after hours)? |
Member
|
Please run |
beikov
reviewed
Jun 30, 2026
beikov
reviewed
Jun 30, 2026
…s hierarchy Previously only inspected the generator's direct generic interfaces, so it failed to find the annotation type argument when Previously only inspected the generator's direct generic interfaces, so it failed to find the annotation type argument when a generator inherited AnnotationBasedGenerator from an abstract base class. Use to resolve the argument through the full class hierarchy.
This was referenced Jul 1, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to file this as a JIRA issue, but I always get a permission error whentrying to create a ticket, so I'm posting it here instead. -> I reported issue in https://discourse.hibernate.org/t/annotationbasedgenerator-is-not-initialized-when-the-interface-is-implemented-by-an-abstract-superclass-instead-of-the-concrete-class-after-upgrading-to-hibernate-7-3-7-4/12354. Here is the PR with an accompanying test.
Example
Abstract base class implementing the interface:
Concrete generator referenced by a @ValueGenerationType annotation:
Since 7.3/7.4 Hibernate fails to with AssertionFailure: "Could not find implementing interface". The change was introduced by
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
Please make sure that the following tasks are completed:
Tasks specific to HHH-20614 (Bug):
migration-guide.adocOR check there are no breaking changeshttps://hibernate.atlassian.net/browse/HHH-20614