Fix background commander thread arguments#32
Open
IlyaKochnev wants to merge 2 commits into
Open
Conversation
|
already mentioned 2 weeks ago here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commander(...)call from failing with a missing-argumentTypeErrorapply-usersexecution after user changes in the panelRoot cause
cmd_in_backrequires acmdargument, but the thread was created withoutargs. As a result, the thread failed before spawningcommon/commander.py, while the caller still returned success.This left generated service configurations stale. One observed consequence was that a user deleted from the UI remained in Telemt's generated
config.toml.Testing
python3 -m py_compile hiddifypanel/panel/run_commander.pygit diff --checkverified the failure on Hiddify Manager/Panel 12.3.3 from the logged traceback:
Fixes hiddify/Hiddify-Manager#5498