ci(workflow-fix): add commitish build handling to determinism checks#25525
ci(workflow-fix): add commitish build handling to determinism checks#25525andrewb1269 wants to merge 7 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
354d460 to
5508026
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #25525 +/- ##
=========================================
Coverage 75.11% 75.11%
Complexity 11548 11548
=========================================
Files 2585 2585
Lines 101419 101419
Branches 11241 11241
=========================================
Hits 76179 76179
Misses 21335 21335
Partials 3905 3905 🚀 New features to boost your workflow:
|
5508026 to
e2a41e2
Compare
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
e2a41e2 to
32f1949
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the Gradle and Docker build determinism verification workflows to avoid snapshot-style collisions by deriving a “commitish” prefix from the branch name and using it to set the Gradle project version before building, while also moving baseline artifacts into baselines-commitish paths (e.g., .github/workflows/zxc-verify-gradle-build-determinism.yaml:90-120, .github/workflows/zxc-verify-docker-build-determinism.yaml:99-164).
Changes:
- Compute a normalized branch-based commit prefix and expose it as a step output (Gradle workflow:
.github/workflows/zxc-verify-gradle-build-determinism.yaml:90-99and277-286; Docker workflow:.github/workflows/zxc-verify-docker-build-determinism.yaml:99-108). - Run
./gradlew versionAsPrefixedCommitwith the computed prefix before assembling artifacts (Gradle workflow:117-124and287-292; Docker workflow:158-165). - Store/read baselines under
.../baselines-commitishinstead of.../baselines(Gradle workflow:103-105; Docker workflow:112-114).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/zxc-verify-gradle-build-determinism.yaml | Adds branch-derived commit prefixing and applies it to Gradle versioning; moves GCS baseline location to baselines-commitish. |
| .github/workflows/zxc-verify-docker-build-determinism.yaml | Adds branch-derived commit prefixing and applies it to Gradle versioning used for Docker build inputs; moves GCS baseline location to baselines-commitish. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
Description:
This pull request updates the CI workflows for verifying Gradle and Docker build determinism. The main changes add logic to compute a commit-based prefix from the branch name and use it to update the Gradle project version before building artifacts. Additionally, baseline artifact paths are updated for better organization. These changes help ensure that builds are uniquely identified by branch and commit, improving traceability and reproducibility.
Commit Prefix and Versioning Enhancements:
zxc-verify-docker-build-determinism.yamlandzxc-verify-gradle-build-determinism.yamlworkflows. This prefix is used to uniquely identify builds from different branches or commits. [1] [2] [3]Baseline Artifact Path Changes:
baselines-commitishinstead ofbaselines, improving organization and clarity of stored artifacts. [1] [2]Related issue(s):
Fixes #25492