Skip to content

feat: estimate io utilization in the network simulation#25642

Open
abies wants to merge 15 commits into
mainfrom
25614-network-simulation-io
Open

feat: estimate io utilization in the network simulation#25642
abies wants to merge 15 commits into
mainfrom
25614-network-simulation-io

Conversation

@abies
Copy link
Copy Markdown
Contributor

@abies abies commented May 28, 2026

Description:
Extend MOP network simulator with bandwidth analysis.
Allow running multiple simulations in a single test and report summary results.

Related issue(s):

Fixes #25614

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@abies
feat: estimate io utilization in the network simulation
8b1587e 
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
@abies abies added this to the v0.76 milestone May 28, 2026
@abies abies requested review from lpetrovic05 and poulok May 28, 2026 12:35
@abies abies self-assigned this May 28, 2026
@abies abies requested review from a team as code owners May 28, 2026 12:35
@abies abies requested a review from leninmehedy May 28, 2026 12:35
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 28, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@abies abies removed the request for review from leninmehedy May 28, 2026 12:36
@lfdt-bot
Copy link
Copy Markdown

lfdt-bot commented May 28, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

lpetrovic05
lpetrovic05 reviewed May 28, 2026
View reviewed changes
Comment thread ...network-simulation/src/test/java/org/hiero/consensus/network/simulation/SimulationStats.java Outdated
.forEach(c2cs::add);

numBytes += engineOutputs.stream()
.map(ConsensusEngineOutput::consensusRounds)
Copy link
Copy Markdown
Contributor

@lpetrovic05 lpetrovic05 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not be looking at consensus events but pre-consensus events in this same output

Copy link
Copy Markdown
Contributor Author

@abies abies May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the general correctness; we don't expect it to produce any different numbers in the actual test?

Copy link
Copy Markdown
Contributor

@lpetrovic05 lpetrovic05 Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the numbers will be different, there will always be more pre-consensus events than consensus events. i think we are more interested in the number of events that are gossiped, than the number that reach consensus

Copy link
Copy Markdown
Contributor Author

@abies abies Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

poulok and others added 11 commits May 28, 2026 09:12
@poulok @netopyr
docs: reconnect architecture document (#25639)
f47183b 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Co-authored-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@AlexKehayov
chore: update throttling docs (#25618)
152f5dd 
Signed-off-by: Alex Kehayov <aleks.kehayov@limechain.tech>
@netopyr @poulok
docs: Add Consensus-Excecution Boundary Document (#25379)
a3f3fce 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Co-authored-by: Kelly Greco <82919061+poulok@users.noreply.github.com>
@joshmarinacci
ci(feat): convert usage of inline JSON to gomplate templates. (#25622)
5d2505d 
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@ibankov
fix(history): retry WRAPS publication after a library-not-ready noop (#…
cf913dc 
…25651)

Signed-off-by: Ivan Bankov <ivan.bankov@limechain.tech>
@netopyr
docs: Add Wiring Framework Architecture Document (#25376)
e657c2b 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@poulok @netopyr
docs: Add Signed State Management Architecture Document (#25657)
796905b 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Co-authored-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@poulok
chore: Add new doc folder to CODEOWNERS (#25655)
f88165c 
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
@poulok @netopyr
docs: Add Health & Backpressure Architecture Document (#25658)
eb37e5b 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Co-authored-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@abies
feat: estimate io utilization in the network simulation
b1023ab 
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
@abies
Merge remote-tracking branch 'origin/25614-network-simulation-io' int…
81b4fca 
…o 25614-network-simulation-io
@abies abies requested a review from a team as a code owner May 30, 2026 17:27
abies added 3 commits May 30, 2026 19:44
@abies
feat: estimate io utilization in the network simulation
dfcd225 
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
@abies
feat: estimate io utilization in the network simulation
8a0c2cb 
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
@abies
feat: estimate io utilization in the network simulation
96fb9f8 
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...dera/node/app/history/impl/WrapsHistoryProver.java 92.59% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #25642   +/-   ##
=========================================
  Coverage     75.10%   75.11%           
  Complexity    11548    11548           
=========================================
  Files          2585     2585           
  Lines        101398   101419   +21     
  Branches      11233    11240    +7     
=========================================
+ Hits          76156    76179   +23     
  Misses        21335    21335           
+ Partials       3907     3905    -2
Files with missing lines Coverage Δ Complexity Δ
...dera/node/app/history/impl/WrapsHistoryProver.java 82.47% <92.59%> (+1.62%) 0.00 <0.00> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpetrovic05 lpetrovic05 lpetrovic05 left review comments

@poulok poulok Awaiting requested review from poulok

At least 1 approving review is required to merge this pull request.

Assignees

@abies abies

Labels

None yet

Projects

None yet

Milestone

v0.76

Development

Successfully merging this pull request may close these issues.

Extend MOP network simulator with I/O estimation

8 participants

@abies @lfdt-bot @lpetrovic05 @poulok @AlexKehayov @netopyr @joshmarinacci @ibankov