feat: Change default number of max other parents to 4#25669
Draft
abies wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #25669 +/- ##
============================================
+ Coverage 75.11% 75.14% +0.02%
Complexity 11548 11548
============================================
Files 2585 2585
Lines 101419 101419
Branches 11241 11241
============================================
+ Hits 76179 76209 +30
+ Misses 21335 21302 -33
- Partials 3905 3908 +3
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Artur Biesiadowski <artur.biesiadowski@swirldslabs.com>
✅ All tests passed ✅🏷️ Commit: 0f365fb Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Change default number of other parents to 4, which seems to be currently the best tradeoff between increased IO utilization and improved latency.
Related issue(s): #24319
Fixes #
Notes for reviewer:
Checklist