Skip to content

feat(hooks): implement account hook create/delete support across base, Spring, MicroProfile, and docs#123

Open
amkr6207 wants to merge 5 commits into
hiero-ledger:mainfrom
amkr6207:feat/issue-65-hooks-implementation
Open

feat(hooks): implement account hook create/delete support across base, Spring, MicroProfile, and docs#123
amkr6207 wants to merge 5 commits into
hiero-ledger:mainfrom
amkr6207:feat/issue-65-hooks-implementation

Conversation

@amkr6207

@amkr6207 amkr6207 commented May 3, 2026

Copy link
Copy Markdown
Contributor

Description:

Follow-up to #72 (API contracts part)

Implement the remaining scope of #65 by adding account hook create/delete support in base APIs, exposing it through Spring and MicroProfile, and documenting usage.

  • Add AccountClient.updateAccountHooks(...) high-level API
  • Add hook models and protocol request/result types
  • Implement protocol-layer account hook update transaction flow
  • Add/extend unit tests for request validation and client wiring
  • Add Spring and MicroProfile service exposure tests
  • Update README and docs with hook lifecycle usage examples

Related issue(s):

Fixes #65

Notes for reviewer:
Local spotless:check, compile, and test-compile pass.

Checklist

  • Documented (README/docs)
  • Tested (unit + framework exposure tests)

@amkr6207

amkr6207 commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

@Ndacyayisenga-droid, @manishdait Could you please review this PR?

@amkr6207

amkr6207 commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

@Ndacyayisenga-droid, @manishdait

This CI failure looks unrelated to the code changes.

deploy-preview is trying to push to gh-pages, but for this fork PR the action does not have write permission to hiero-ledger/hiero-enterprise-java (403 for github-actions[bot]).

Could you please re-run this check (or confirm the expected behavior for fork PRs)?

@Ndacyayisenga-droid

Copy link
Copy Markdown
Member

@Ndacyayisenga-droid, @manishdait

This CI failure looks unrelated to the code changes.

deploy-preview is trying to push to gh-pages, but for this fork PR the action does not have write permission to hiero-ledger/hiero-enterprise-java (403 for github-actions[bot]).

Could you please re-run this check (or confirm the expected behavior for fork PRs)?

Don't worry about the deploy preview

@amkr6207

amkr6207 commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

@Ndacyayisenga-droid, @manishdait
This CI failure looks unrelated to the code changes.
deploy-preview is trying to push to gh-pages, but for this fork PR the action does not have write permission to hiero-ledger/hiero-enterprise-java (403 for github-actions[bot]).
Could you please re-run this check (or confirm the expected behavior for fork PRs)?

Don't worry about the deploy preview

@Ndacyayisenga-droid, since PR #72 has been approved, could you please review PR #123 as well? Both PRs are part of issue #65.

Comment thread README.md Outdated
@manishdait

Copy link
Copy Markdown
Contributor

@amkr6207, can you please resolve the conflicts

amkr6207 added 3 commits May 6, 2026 14:42
…ng, MicroProfile, and docs

Signed-off-by: Aman <amkr6207@gmail.com>
Signed-off-by: Aman <amkr6207@gmail.com>
Signed-off-by: Aman <amkr6207@gmail.com>
@amkr6207 amkr6207 force-pushed the feat/issue-65-hooks-implementation branch from 49097c8 to e4c2c13 Compare May 6, 2026 09:20
@amkr6207

amkr6207 commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

@amkr6207, can you please resolve the conflicts

Resolved it

@amkr6207

amkr6207 commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

@Ndacyayisenga-droid, @manishdait

Deploy preview CI failure is unrelated to the code changes. PTAL. Thanks!

@manishdait

Copy link
Copy Markdown
Contributor

@amkr6207, Please add an e2e for the changes in the spring and microprofile module

Signed-off-by: Aman <amkr6207@gmail.com>
@amkr6207

amkr6207 commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

@amkr6207, Please add an e2e for the changes in the spring and microprofile module

@Ndacyayisenga-droid, @manishdait

Added e2e coverage for the hook flow in both Spring and MicroProfile. PTAL. Thanks!

Signed-off-by: Aman <amkr6207@gmail.com>
@amkr6207

amkr6207 commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

@Ndacyayisenga-droid, @manishdait

After adding the e2e hook-flow coverage for Spring and MicroProfile, CI failed because the target environment returned HOOKS_NOT_ENABLED. So I updated the Spring and MicroProfile hook e2e tests to skip when the target environment returns HOOKS_NOT_ENABLED.

PTAL. Thanks!

@amkr6207

Copy link
Copy Markdown
Contributor Author

@Ndacyayisenga-droid, @manishdait

Deploy preview CI failure is unrelated to the code changes. PTAL. Thanks!

@amkr6207

Copy link
Copy Markdown
Contributor Author

@Ndacyayisenga-droid, @manishdait Could you please review this PR?

@aceppaluni aceppaluni added the status: ready-for-review PR is ready to be reviewed by team member label May 22, 2026

@aceppaluni aceppaluni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amkr6207 This is a great follow-up to #65

I took a look at the Current repo SDK (com.hedera.hashgraph:sdk:2.71.0) and it exposes getHook() and getHookId(). However I understand this PR is support for create/delete.

Will there be a follow-up PR for these actions?

@aceppaluni aceppaluni added the maintianer/committer proposed question team member proposed a question label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintianer/committer proposed question team member proposed a question status: ready-for-review PR is ready to be reviewed by team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Hooks create/manage support to hiero-enterprise-java high-level APIs

4 participants