feat(hooks): implement account hook create/delete support across base, Spring, MicroProfile, and docs#123
Conversation
5ece92b to
a1d4a69
Compare
|
@Ndacyayisenga-droid, @manishdait Could you please review this PR? |
|
@Ndacyayisenga-droid, @manishdait This CI failure looks unrelated to the code changes.
Could you please re-run this check (or confirm the expected behavior for fork PRs)? |
Don't worry about the deploy preview |
@Ndacyayisenga-droid, since PR #72 has been approved, could you please review PR #123 as well? Both PRs are part of issue #65. |
|
@amkr6207, can you please resolve the conflicts |
…ng, MicroProfile, and docs Signed-off-by: Aman <amkr6207@gmail.com>
Signed-off-by: Aman <amkr6207@gmail.com>
Signed-off-by: Aman <amkr6207@gmail.com>
49097c8 to
e4c2c13
Compare
Resolved it |
|
@Ndacyayisenga-droid, @manishdait Deploy preview CI failure is unrelated to the code changes. PTAL. Thanks! |
|
@amkr6207, Please add an e2e for the changes in the spring and microprofile module |
Signed-off-by: Aman <amkr6207@gmail.com>
@Ndacyayisenga-droid, @manishdait Added e2e coverage for the hook flow in both Spring and MicroProfile. PTAL. Thanks! |
Signed-off-by: Aman <amkr6207@gmail.com>
|
@Ndacyayisenga-droid, @manishdait After adding the e2e hook-flow coverage for Spring and MicroProfile, CI failed because the target environment returned PTAL. Thanks! |
|
@Ndacyayisenga-droid, @manishdait Deploy preview CI failure is unrelated to the code changes. PTAL. Thanks! |
|
@Ndacyayisenga-droid, @manishdait Could you please review this PR? |
Description:
Follow-up to #72 (API contracts part)
Implement the remaining scope of #65 by adding account hook create/delete support in base APIs, exposing it through Spring and MicroProfile, and documenting usage.
AccountClient.updateAccountHooks(...)high-level APIRelated issue(s):
Fixes #65
Notes for reviewer:
Local
spotless:check,compile, andtest-compilepass.Checklist