feat: add ReceiveRecordInterceptor to MicroProfile and implement UINT64 support#128
Open
Aamir377300 wants to merge 1 commit into
Open
Conversation
…ent UINT64 support Signed-off-by: Aamir377300 <belalaamirkhan@gmail.com>
Aamir377300
force-pushed
the
feat/add-interceptor-to-microprofile-client
branch
from
27320b9 to
7b72d10
Compare
Contributor
Author
|
@Ndacyayisenga-droid please review this PR . I’m open to any suggestions or feedback for improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues identified in the MicroProfile module and the base numeric datatypes:
ReceiveRecordInterceptorinClientProvider.java, matching the behavior in the Spring module. This enables consistent observability and metrics across frameworks.UINT64support inBigIntegerBasedNumericDatatypes.javausingBigIntegerfor range validation. The corresponding TODO inLongBasedNumericDatatypes.javahas been removed.Changes
Instance<ReceiveRecordInterceptor>inClientProviderand applied it toProtocolLayerClient.UINT64toBigIntegerBasedNumericDatatypes.UINT64TODO fromLongBasedNumericDatatypes.Verification
./mvnw clean compile -DskipTests.This resolves issue #124. Looking forward to your feedback.