fix(microprofile): implement checkVerification and verify methods in ContractVerificationClientImpl (issue #133)#135
Open
saksham869 wants to merge 5 commits into
Conversation
Signed-off-by: satyam mishra <mishrasatyam3456@gmail.com>
…ider (issue hiero-ledger#131) Signed-off-by: satyam mishra <mishrasatyam3456@gmail.com>
…ider (issue hiero-ledger#131) Signed-off-by: satyam mishra <mishrasatyam3456@gmail.com>
…ider (issue hiero-ledger#131) Signed-off-by: satyam mishra <mishrasatyam3456@gmail.com>
…ContractVerificationClientImpl (issue hiero-ledger#133) Signed-off-by: satyam mishra <mishrasatyam3456@gmail.com>
manishdait
requested changes
May 7, 2026
manishdait
left a comment
manishdait
left a comment
Contributor
There was a problem hiding this comment.
@saksham869 Thanks for the PR, there are some changes related to the cli example which are out of scope for this PR. Please remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ContractVerificationClientImpl.javain the MicroProfile module had twomethods throwing
UnsupportedOperationException("Not implemented"):checkVerification(ContractId)verify(ContractId, String, Map<String, String>)MicroProfile users could not verify smart contracts at all — both methods
failed at runtime.
Fix
Implemented both methods using JAX-RS (
jakarta.ws.rs) and Jakarta JSONAPIs, following the same logic as the Spring module
(
ContractVerificationClientImplementation.java)./check-by-addressesto check verification status/verifyto submit contract source for verification/files/to compare contract file contentNo new dependencies added — uses libraries already available in the
MicroProfile module.
Closes #133
cc @hendrikebbers @manishdait