Fix MicroProfile transaction queries: wrong endpoint, broken serialization, and JSON parsing errors by alejandroGM0 · Pull Request #56 · hiero-ledger/hiero-enterprise-java

alejandroGM0 · 2026-04-14T18:07:45Z

Fixes #55

Summary

Fixes all four MirrorNodeClientImpl transaction query methods that were hitting /api/v1/tokens instead of /api/v1/transactions, making them return token listings instead of transaction data. Also fixes enum serialization so the mirror-node receives the correct parameter values.

Beyond the endpoint fix, the JSON response parser (MirrorNodeJsonConverterImpl) crashes on live mirror-node transaction responses due to type mismatches and null handling errors. These are fixed together since the parser bugs are on the same code path and would be the immediate next failure after correcting the endpoint.

Changes

`MirrorNodeClientImpl.java` (MicroProfile)

Extract TRANSACTIONS_PATH, TOKENS_PATH, TOPICS_PATH constants
Fix endpoint: /api/v1/tokens -> /api/v1/transactions in all 4 transaction query methods
Fix queryTransactionsByAccountAndType: type -> type.getType() (sends protocol string CRYPTOCREATEACCOUNT instead of Java enum ACCOUNT_CREATE)
Fix queryTransactionsByAccountAndResult: result -> result.name()
Fix queryTransactionsByAccountAndModification: type -> type.name()

`MirrorNodeJsonConverterImpl.java` (MicroProfile)

Fix charged_tx_fee, amount, serial_number parsing: Long.parseLong(getString(...)) -> getJsonNumber(...).longValue() (mirror-node returns JSON numbers)
Fix bytes, entity_id, node parsing: getString() -> getNullableString() helper (mirror-node returns JSON null for these fields)
Fix parent_consensus_timestamp null check: .get(...).asJsonObject() == null -> jsonObject.isNull(key)
Fix jsonArrayToStream: remove throw on empty array (empty result sets are valid)

`MirrorNodeClientImpl.java` (Spring)

Extract ACCOUNTS_PATH, TRANSACTIONS_PATH, TOKENS_PATH, TOPICS_PATH constants (consistency, no bug fix)

New tests

MirrorNodeClientImplPathTest — 5 unit tests verifying path construction (no live network needed)
TransactionRepositoryTest — 5 integration tests matching the existing Spring TransactionRepositoryTest

How verified

Unit tests pass: mvn test -pl hiero-enterprise-microprofile -Dtest=MirrorNodeClientImplPathTest (5/5)
Confirmed via git show HEAD:...MirrorNodeClientImpl.java that the original code uses /api/v1/tokens
Confirmed via live Hedera mainnet mirror-node that /api/v1/tokens?account.id=0.0.98 returns token data, while /api/v1/transactions?account.id=0.0.98 returns transaction data
Confirmed mirror-node rejects transactiontype=ACCOUNT_CREATE but accepts transactiontype=CRYPTOCREATEACCOUNT

Ndacyayisenga-droid

Thanks @alejandroGM0. PR looks good.

Could you fix the formatting issues with mvn spotless:apply

And for some reason I can't be able to merge your Prs

…ation, and JSON parsing errors Fix all four MirrorNodeClientImpl transaction query methods that were hitting /api/v1/tokens instead of /api/v1/transactions, returning token listings instead of transaction data. Also fix enum serialization so the mirror-node receives correct parameter values. MirrorNodeClientImpl (MicroProfile): - Extract TRANSACTIONS_PATH, TOKENS_PATH, TOPICS_PATH constants - Fix endpoint: /api/v1/tokens -> /api/v1/transactions in all 4 methods - Fix queryTransactionsByAccountAndType: type -> type.getType() - Fix queryTransactionsByAccountAndResult: result -> result.name() - Fix queryTransactionsByAccountAndModification: type -> type.name() MirrorNodeJsonConverterImpl (MicroProfile): - Fix charged_tx_fee, amount, serial_number: getString+parseLong -> getJsonNumber - Fix bytes, entity_id, node: getString -> getNullableString helper - Fix parent_consensus_timestamp null check: use jsonObject.isNull() - Fix jsonArrayToStream: remove throw on empty arrays MirrorNodeClientImpl (Spring): - Extract ACCOUNTS_PATH, TRANSACTIONS_PATH, TOKENS_PATH, TOPICS_PATH constants New tests: - MirrorNodeClientImplPathTest: 5 unit tests verifying URL path construction - TransactionRepositoryTest: 5 integration tests matching Spring parity Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

`queryTransactionsByAccountAndType` had a 6-space continuation indent that failed `spotless:check` in CI. Bring it to 8 spaces to match the project format. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

Run `mvn spotless:apply` over the files touched in this PR. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

alejandroGM0 · 2026-04-19T10:04:54Z

Thanks @alejandroGM0. PR looks good.

Could you fix the formatting issues with mvn spotless:apply

And for some reason I can't be able to merge your Prs

Done
I've also fixed the issue with pull requests (it was a git sign problem).

@AddBean

HieroTestProducer is @ApplicationScoped and discovered automatically by CDI. Adding @AddBean(HieroTestProducer.class) registered it a second time, causing WELD-001409 Ambiguous dependencies for HieroTestUtils in TransactionRepositoryTest. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

Previous run hit a flaky mirror-node indexing race in TransactionRepositoryTest.testFindTransactionByAccountId. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

alejandroGM0 · 2026-04-19T23:23:40Z

There seems to be a race condition in the tests causing the flow tests to fail randomly (not always): the test creates a new account and immediately asks the mirror node to list its transactions, but the "by account" index sometimes takes a few hundred ms longer to update than the "by tx-id" one, so the list comes back empty. I'm looking into this.

HieroTestUtils.waitForMirrorNodeRecords() only polls the by-transaction-id index, but tests that assert on results obtained through the by-account index can still observe an empty page for a freshly created account because both indexes are updated independently. Add an overload that, after the existing wait, also polls queryTransactionsByAccount(accountId) until it returns data. Use it in the Spring and MicroProfile tests that assert assertFalse(data.isEmpty()). Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

alejandroGM0 · 2026-04-20T10:02:50Z

There seems to be a race condition in the tests causing the flow tests to fail randomly (not always): the test creates a new account and immediately asks the mirror node to list its transactions, but the "by account" index sometimes takes a few hundred ms longer to update than the "by tx-id" one, so the list comes back empty. I'm looking into this.

@Ndacyayisenga-droid
The last commit should fix a pre-existing race in HieroTestUtils.waitForMirrorNodeRecords(): it only polled the tx-id index, while findByAccount hits a separate account-id index that can lag. Added a waitForMirrorNodeRecords(AccountId) overload and used it in the Spring and MicroProfile testFindTransactionByAccountId

Ndacyayisenga-droid · 2026-04-21T23:24:02Z

Not part of your changes but throwing UnsupportedOperationException for now here makes more sense

Ndacyayisenga-droid · 2026-04-21T23:24:35Z

Ndacyayisenga-droid · 2026-04-21T23:29:08Z

+   * A test subclass that captures the path passed to RestBasedPage without making any HTTP call.
+   * This lets us verify the URL path construction in isolation.
+   */
+  static class PathCapturingMirrorNodeClient extends MirrorNodeClientImpl {


This is never referenced anywhere, and the comment describes capturing the path without HTTP, but nothing in the suite does that yet. That makes the class look like a leftover spike. I would suggest we remove if we dont use it anywhere

Ndacyayisenga-droid · 2026-04-22T00:53:10Z

+  }
+
+  @Test
+  void testFindTransactionByAccountIdGiveEmptyListForAccountIdWithZeroTransaction()


Method too long I would rename it to something like findByAccountReturnsEmptyWhenNoTransactions()

Ndacyayisenga-droid · 2026-04-22T01:07:17Z

+    final Page<TransactionInfo> page =
+        transactionRepository.findByAccountAndType(
+            account.accountId(), TransactionType.ACCOUNT_CREATE);
+    Assertions.assertNotNull(page);


assertNotNull(page) does not prove the repository or mirror client applied the filter, an empty page or wrong rows would still pass. Consider asserting page.getData() is non-empty when you expect activity, and that every returned TransactionInfo matches the requested type / result / modification (or assert on fields you trust from the mirror response).

Ndacyayisenga-droid · 2026-04-22T01:07:31Z

+    hieroTestUtils.waitForMirrorNodeRecords();
+    final Page<TransactionInfo> page =
+        transactionRepository.findByAccountAndResult(account.accountId(), Result.SUCCESS);
+    Assertions.assertNotNull(page);


Ndacyayisenga-droid · 2026-04-22T01:09:56Z

+    hieroTestUtils.waitForMirrorNodeRecords();
+    final Page<TransactionInfo> page =
+        transactionRepository.findByAccountAndModification(
+            account.accountId(), BalanceModification.DEBIT);


I would instead use CREDIT as DEBIT often yields no rows for a brand-new id!

Ndacyayisenga-droid · 2026-04-22T01:11:04Z

+    final Page<TransactionInfo> page =
+        transactionRepository.findByAccountAndModification(
+            account.accountId(), BalanceModification.DEBIT);
+    Assertions.assertNotNull(page);


Ndacyayisenga-droid · 2026-04-22T01:23:57Z

+    final Account account = accountClient.createAccount(1);
+    hieroTestUtils.waitForMirrorNodeRecords(account.accountId());
+    final Page<TransactionInfo> page = transactionRepository.findByAccount(account.accountId());
+    Assertions.assertNotNull(page);


If transactionRepository.findByAccount(...) guarantees a non-null Page, then assertNotNull(page) is redundant since page.getData() would already fail if null. Fine to keep for readability, otherwise you could rely on the getData() assertions alone.

Keep the PR focused on the maintainer feedback by tightening the MirrorNode query tests, centralizing null-check messages, and redacting test config values during local runs. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

Keep the current PR focused on the maintainer-requested transaction query changes. The TestConfigSource logging change is being handled separately. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

Keep the null-check message extraction aligned with the repository formatting rules so the MicroProfile Spotless check passes in CI. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

alejandroGM0 force-pushed the fix/microprofile-transaction-queries branch from 67cea61 to 4d1f4ea Compare April 14, 2026 18:09

alejandroGM0 mentioned this pull request Apr 16, 2026

Hiero: Extending Hiero Enterprise Java with Smart Contract Event and Log APIs LF-Decentralized-Trust-Mentorships/mentorship-program#70

Open

Ndacyayisenga-droid reviewed Apr 19, 2026

View reviewed changes

alejandroGM0 added 3 commits April 19, 2026 12:00

style: fix Spotless indent in MirrorNodeClientImpl

312aaa6

`queryTransactionsByAccountAndType` had a 6-space continuation indent that failed `spotless:check` in CI. Bring it to 8 spaces to match the project format. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

style: apply Spotless formatting

3baa7aa

Run `mvn spotless:apply` over the files touched in this PR. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

alejandroGM0 force-pushed the fix/microprofile-transaction-queries branch from 4088bd7 to 3baa7aa Compare April 19, 2026 10:00

alejandroGM0 added 2 commits April 19, 2026 14:24

chore: retrigger CI

d73f7ad

Previous run hit a flaky mirror-node indexing race in TransactionRepositoryTest.testFindTransactionByAccountId. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

Ndacyayisenga-droid reviewed Apr 22, 2026

View reviewed changes

Ndacyayisenga-droid requested review from hendrikebbers and manishdait April 22, 2026 01:32

Ndacyayisenga-droid requested changes Apr 22, 2026

View reviewed changes

alejandroGM0 added 2 commits April 23, 2026 17:28

revert: restore TestConfigSource value logging

55cb10b

Keep the current PR focused on the maintainer-requested transaction query changes. The TestConfigSource logging change is being handled separately. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

alejandroGM0 force-pushed the fix/microprofile-transaction-queries branch from 6511ce9 to 55cb10b Compare April 23, 2026 15:28

alejandroGM0 added 2 commits April 23, 2026 17:33

Merge branch 'main' into fix/microprofile-transaction-queries

d54e636

Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

style: apply Spotless formatting to review follow-up

2e12487

Keep the null-check message extraction aligned with the repository formatting rules so the MicroProfile Spotless check passes in CI. Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>

Conversation

alejandroGM0 commented Apr 14, 2026

Summary

Changes

MirrorNodeClientImpl.java (MicroProfile)

MirrorNodeJsonConverterImpl.java (MicroProfile)

MirrorNodeClientImpl.java (Spring)

New tests

How verified

Uh oh!

Ndacyayisenga-droid left a comment

Choose a reason for hiding this comment

Uh oh!

alejandroGM0 commented Apr 19, 2026

Uh oh!

alejandroGM0 commented Apr 19, 2026

Uh oh!

alejandroGM0 commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`MirrorNodeClientImpl.java` (MicroProfile)

`MirrorNodeJsonConverterImpl.java` (MicroProfile)

`MirrorNodeClientImpl.java` (Spring)

alejandroGM0 commented Apr 20, 2026 •

edited

Loading