fix(spring): preserve RestClient customizers#92
Open
alejandroGM0 wants to merge 1 commit intohiero-ledger:mainfrom
Open
fix(spring): preserve RestClient customizers#92alejandroGM0 wants to merge 1 commit intohiero-ledger:mainfrom
alejandroGM0 wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>
alejandroGM0
force-pushed
the
fix/spring-restclient-observability-clean
branch
from
8f3a9af to
05e6bdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Boot’s
RestClient.Builderwhen present so Hiero’s SpringRestClientinstances inherit Boot HTTP client customizations (observability/metrics/tracing when enabled).Changes
HieroAutoConfiguration:ObjectProvider<RestClient.Builder>+getIfAvailable(RestClient::builder); mirror node usesclone().baseUrl(...).ContractVerificationClientImplementation: build client from injectedRestClient.Builder(noRestClient.create()).Why
Manual
RestClient.create()/ rawRestClient.builder()can bypass Boot’s builder pipeline.Verify
./mvnw -pl hiero-enterprise-spring -am test