Skip to content

fix(base): clean misleading validation messages and contract call naming#93

Open
alejandroGM0 wants to merge 1 commit intohiero-ledger:mainfrom
alejandroGM0:fix/base-misleading-messages-api-naming
Open

fix(base): clean misleading validation messages and contract call naming#93
alejandroGM0 wants to merge 1 commit intohiero-ledger:mainfrom
alejandroGM0:fix/base-misleading-messages-api-naming

Conversation

@alejandroGM0
Copy link
Copy Markdown
Contributor

Summary

This PR cleans up misleading validation messages and confusing naming in the base module.

Changes

  • fixed incorrect null-check messages for accountId in:
    • AccountClient
    • Account
    • AccountBalanceRequest
    • MirrorNodeClient
  • fixed incorrect null-check messages in:
    • TransactionRepository (result instead of type)
    • AccountCreateResult (newAccount instead of newAccountId)
    • SmartContractClientImpl (protocolLayerClient instead of protocolLevelClient)
    • FileClientImpl (protocolLayerClient instead of protocolLevelClient)
    • ReceiveRecordInterceptor (function instead of handler)
  • clarified ReceiveRecordInterceptor docs so handler and function are described consistently
  • renamed ContractCallRequest parameter naming from constructorParams to functionParams
  • fixed invalid validation text in ContractCallRequest
    • maxTransactionFee must be at >= null -> maxTransactionFee must be non-negative
    • transactionValidDuration must be at >= zero -> transactionValidDuration must be positive
  • updated ProtocolLayerClientImpl to use request.functionParams() for contract call execution

Verification

Passed focused tests:

  • ProtocolLayerDataCreationTests
  • AccountClientImplTest

Signed-off-by: Alejandro <26930485+alejandroGM0@users.noreply.github.com>
@alejandroGM0 alejandroGM0 force-pushed the fix/base-misleading-messages-api-naming branch from bdd2acc to ec0042d Compare April 27, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant