Skip to content

chore: convert FeeComponentsUnitTests.cc line endings to LF - #1693

Open
gargi-gif wants to merge 1 commit into
hiero-ledger:mainfrom
gargi-gif:main
Open

chore: convert FeeComponentsUnitTests.cc line endings to LF#1693
gargi-gif wants to merge 1 commit into
hiero-ledger:mainfrom
gargi-gif:main

Conversation

@gargi-gif

@gargi-gif gargi-gif commented Jul 10, 2026

Copy link
Copy Markdown

Description:
Convert FeeComponentsUnitTests.cc line endings from Windows-style (CRLF) to Unix-style (LF) to match the rest of the project and prevent spurious diffs.

  • Convert CRLF to LF in src/sdk/tests/unit/FeeComponentsUnitTests.cc

Related issue(s):

Fixes #1616

Notes for reviewer:
Converted the file using VS Code.
Note: I am developing on Windows, so I was unable to run the linux-x64-debug CMake preset locally. I am relying on the CI/CD pipeline to verify the build and tests.

Checklist

  • Documented (Code comments, README, etc.)
  • [⨉ ] Tested (unit, integration, etc.)

Summary by CodeRabbit

  • Style
    • Normalized formatting and line endings in fee component unit tests without changing test behavior or expected results.

Signed-off-by: gargi <gargich30@gmail.com>
@gargi-gif
gargi-gif requested review from a team as code owners July 10, 2026 18:40
@gargi-gif
gargi-gif requested a review from rwalworth July 10, 2026 18:40
@github-actions

Copy link
Copy Markdown

Hey @gargi-gif 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1616 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd3e41e4-664d-4d03-a244-aef065405115

📥 Commits

Reviewing files that changed from the base of the PR and between a898153 and ece1cee.

📒 Files selected for processing (1)
  • src/sdk/tests/unit/FeeComponentsUnitTests.cc

📝 Walkthrough

Walkthrough

The FeeComponents unit test file was normalized from CRLF to LF line endings. Its test cases, assertions, expected values, and control flow remain unchanged.

Changes

FeeComponents test normalization

Layer / File(s) Summary
Normalize FeeComponents unit test formatting
src/sdk/tests/unit/FeeComponentsUnitTests.cc
The file’s line endings and presentation are normalized while all existing constructor, equality, and inequality assertions remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: converting the unit test file to LF line endings.
Linked Issues check ✅ Passed The PR matches issue #1616 by normalizing the target file to LF without altering test logic or adding unrelated file changes.
Out of Scope Changes check ✅ Passed Only the requested line-ending normalization is present; no unrelated code or file changes appear in the diff.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the status: needs review The pull request is ready for maintainer review label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review The pull request is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Normalize line endings in FeeComponentsUnitTests.cc to LF

1 participant