Skip to content

ci: upgrade solo version to v0.72.0 #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohityadav8 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ci: upgrade solo version to v0.72.0 #1680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b43f849
fix: improve windows include comments
mohityadav8 Jun 14, 2026
386c270
ci: upgrade solo version to v0.72.0
mohityadav8 Jun 14, 2026
0c68a8a
Delete src/sdk/main/include/impl/BaseNode.h
mohityadav8 Jun 14, 2026
1a425f2
Delete src/sdk/main/src/AccountId.cc
mohityadav8 Jun 14, 2026
430e675
Delete src/sdk/main/src/FeeEstimateQuery.cc
mohityadav8 Jun 14, 2026
83d0df4
Delete src/tck/src/TckServer.cc
mohityadav8 Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/zxc-build-library.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ jobs:
id: solo
uses: hiero-ledger/hiero-solo-action@328bc84c3b00a990a151418144fd682a4eb76ea6 # v0.19.0
with:
soloVersion: v0.65.0
soloVersion: v0.72.0

@coderabbitai coderabbitai Bot Jun 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify Hiero Solo v0.72.0 exists and check for compatibility notes or breaking changes.

# Check if v0.72.0 release exists
echo "=== Checking for Hiero Solo v0.72.0 release ==="
gh release view v0.72.0 --repo hiero-ledger/hiero-solo 2>/dev/null || echo "Release v0.72.0 not found"

# List recent releases to confirm version availability
echo -e "\n=== Recent Hiero Solo releases ==="
gh release list --repo hiero-ledger/hiero-solo --limit 10

# Check the action repository for compatibility information
echo -e "\n=== Checking hiero-solo-action compatibility ==="
gh api repos/hiero-ledger/hiero-solo-action/releases/tags/v0.19.0 --jq '.body' 2>/dev/null || echo "Action v0.19.0 release notes not found"

Repository: hiero-ledger/hiero-sdk-cpp

Length of output: 682

Replace soloVersion v0.72.0 with a valid release version.

Hiero Solo v0.72.0 does not exist as a release. The action version v0.19.0 (as specified on line 199) is configured to use Hiero Solo v0.69.0. Update soloVersion to v0.69.0 or verify the correct version against the hiero-solo-action compatibility requirements.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/zxc-build-library.yaml at line 201, The soloVersion
parameter in the zxc-build-library.yaml workflow is set to v0.72.0, which is not
a valid Hiero Solo release version. Update the soloVersion value from v0.72.0 to
v0.69.0 to match the compatible version for the hiero-solo-action version
v0.19.0 that is already specified in the workflow configuration.

installMirrorNode: true
mirrorNodeVersion: v0.153.0
hieroVersion: v0.73.0
Expand Down
259 changes: 0 additions & 259 deletions src/sdk/main/include/impl/BaseNode.h
View file
Open in desktop

This file was deleted.

Loading