feat:Implement EIP-7702 (Type 4 transactions)#2558
Open
Conversation
emiliyank
force-pushed
the
feature/type-4-transactions
branch
2 times, most recently
from
947e1b9 to
5767374
Compare
Signed-off-by: emiliyank <e.kadiyski@gmail.com>
emiliyank
force-pushed
the
feature/type-4-transactions
branch
from
5767374 to
8b75605
Compare
Signed-off-by: emiliyank <e.kadiyski@gmail.com>
emiliyank
force-pushed
the
feature/type-4-transactions
branch
from
a843c91 to
ef984af
Compare
…thod length Signed-off-by: emiliyank <e.kadiyski@gmail.com>
sdk/src/main/java/com/hedera/hashgraph/sdk/EthereumTransactionDataEip7702.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/hedera/hashgraph/sdk/EthereumTransactionDataEip7702.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/hedera/hashgraph/sdk/EthereumTransactionDataEip7702.java
Outdated
Show resolved
Hide resolved
Signed-off-by: emiliyank <e.kadiyski@gmail.com>
Signed-off-by: emiliyank <e.kadiyski@gmail.com>
andrewb1269
approved these changes
Feb 6, 2026
Contributor
andrewb1269
left a comment
andrewb1269
left a comment
There was a problem hiding this comment.
Approve .github/workflows/build.yml file.
hendrikebbers
requested changes
Feb 10, 2026
| return EthereumTransactionDataLegacy.fromBytes(bytes); | ||
| } else { | ||
| return EthereumTransactionDataEip1559.fromBytes(bytes); | ||
| var typeByte = rlpItem.asByte(); |
Member
There was a problem hiding this comment.
I other Java repositories we decided to not use var since it makes the code often less readable. We should do the same in the SDK.
| /** | ||
| * ID of the chain. | ||
| */ | ||
| public byte[] chainId; |
Member
There was a problem hiding this comment.
Since we do not have any setters for all the fields we should make them final. If all fields are final we can convert the class to a record
| throw new IllegalArgumentException("expected RLP element list"); | ||
| } | ||
| List<RLPItem> rlpList = rlpItem.asRLPList().elements(); | ||
| if (rlpList.size() != 13) { |
Member
There was a problem hiding this comment.
We have a lot of magic numbers in this code block. Can we externalize them as constants and add doc to them pls
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
feat:Implement EIP-7702 (Type 4 transactions)
Related issue(s):
Fixes #2541
Checklist